Skip to content

Disable transparent Python upgrades in projects when a patch version is requested via .python-version #19102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zanieb merged 2 commits into from
Apr 21, 2026
+92 −5
Merged

Disable transparent Python upgrades in projects when a patch version is requested via .python-version #19102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23f71bc
Respect patch versions pinned via `.python-version` in `uv sync`
claude Apr 21, 2026
6aef7f0
Apply suggestion from @zanieb
zanieb Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions crates/uv/src/commands/project/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1412,10 +1412,6 @@ impl ProjectEnvironment {
})
.ok();

let upgradeable = python
.as_ref()
.is_none_or(|request| !request.includes_patch());

let workspace_python = WorkspacePython::from_request(
python,
Some(workspace),
Expand All @@ -1425,6 +1421,11 @@ impl ProjectEnvironment {
)
.await?;

let upgradeable = workspace_python
.python_request
.as_ref()
.is_none_or(|request| !request.includes_patch());

match ProjectInterpreter::discover(
workspace,
groups,
Expand Down
88 changes: 87 additions & 1 deletion crates/uv/tests/it/python_upgrade.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use anyhow::Result;
use assert_cmd::assert::OutputAssertExt;
use assert_fs::fixture::FileTouch;
use assert_fs::fixture::{FileTouch, FileWriteStr};
use assert_fs::prelude::PathChild;
use uv_python::managed::platform_key_from_env;
use uv_static::EnvVars;
Expand Down Expand Up @@ -838,3 +838,89 @@ fn python_upgrade_build_version() {
Python 3.12 is already on the latest supported patch release
");
}

// Regression test for <https://github.com/astral-sh/uv/issues/19100>.
//
// A virtual environment created by `uv sync` should pin to a patch version
// recorded in `.python-version` rather than symlinking to the mutable
// minor-version directory, which would be silently upgraded by a later
// `uv python install` of a newer patch release.
#[test]
fn python_sync_honors_pinned_patch_version() -> Result<()> {
let context = uv_test::test_context_with_versions!(&[])
.with_python_download_cache()
.with_filtered_python_keys()
.with_filtered_exe_suffix()
.with_managed_python_dirs()
.with_filtered_latest_python_versions();

let pyproject_toml = context.temp_dir.child("pyproject.toml");
pyproject_toml.write_str(
r#"
[project]
name = "project"
version = "0.1.0"
requires-python = ">=3.10"
"#,
)?;

// Install an earlier patch version
uv_snapshot!(context.filters(), context.python_install().arg("3.10.17"), @r"

@konstin konstin Apr 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to reuse a version here to avoid downloading and installing another version?

@zanieb zanieb Apr 21, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by reuse? It requires a managed install operation to cover the transparent upgrade behavior.

success: true
exit_code: 0
----- stdout -----

----- stderr -----
Installed Python 3.10.17 in [TIME]
+ cpython-3.10.17-[PLATFORM] (python3.10)
");

// Pin the project to the older patch version before the environment exists
uv_snapshot!(context.filters(), context.python_pin().arg("3.10.17"), @r"
success: true
exit_code: 0
----- stdout -----
Pinned `.python-version` to `3.10.17`

----- stderr -----
");

// Create the environment via `uv sync`
uv_snapshot!(context.filters(), context.sync(), @r"
success: true
exit_code: 0
----- stdout -----

----- stderr -----
Using CPython 3.10.17
Creating virtual environment at: .venv
Resolved 1 package in [TIME]
Checked in [TIME]
");

// Install a newer patch version, which moves the mutable `cpython-3.10`
// minor-version link to the newer release.
uv_snapshot!(context.filters(), context.python_upgrade().arg("3.10"), @r"
success: true
exit_code: 0
----- stdout -----

----- stderr -----
Installed Python 3.10.[LATEST] in [TIME]
+ cpython-3.10.[LATEST]-[PLATFORM] (python3.10)
");

// The environment should continue to report the pinned patch version.
uv_snapshot!(context.filters(), context.run().arg("python").arg("--version"), @r"
success: true
exit_code: 0
----- stdout -----
Python 3.10.17

----- stderr -----
Resolved 1 package in [TIME]
Checked in [TIME]
");

Ok(())
}
Loading