Skip to content

Require git refs in URLs to be percent-encoded #19320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
woodruffw merged 2 commits into from
May 7, 2026
Merged

Require git refs in URLs to be percent-encoded #19320

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
726c580
Require git refs in URLs to be percent-encoded
woodruffw May 7, 2026
72a0d2a
Add a backstop test for SSH usernames
woodruffw May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add a backstop test for SSH usernames 
Signed-off-by: William Woodruff <william@yossarian.net>
  • Loading branch information
@woodruffw
woodruffw committed May 7, 2026
commit 72a0d2a2c57c54d1cbe5f7ff70caf570c4de0c20
15 changes: 15 additions & 0 deletions crates/uv-git-types/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,21 @@ mod tests {
Ok(())
}

#[test]
fn parse_ssh_url_with_username_and_percent_encoded_reference()
-> Result<(), Box<dyn std::error::Error>> {
let url = DisplaySafeUrl::parse("ssh://git@github.com/example/example.git@abc%401.2.3")?;
let git = GitUrl::try_from(url)?;

assert_eq!(
git.url().as_str(),
"ssh://git@github.com/example/example.git"
);
assert_eq!(git.reference().as_str(), Some("abc@1.2.3"));

Ok(())
}

#[test]
fn reject_ambiguous_reference() -> Result<(), Box<dyn std::error::Error>> {
let url = DisplaySafeUrl::parse("https://example.com/pkg.git@dev@1.2.3")?;
Expand Down
Loading