Skip to content

Use standard rendering for tool requirement errors #20160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zanieb merged 1 commit into from
Jul 7, 2026
+17 −11
Merged

Use standard rendering for tool requirement errors #20160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions crates/uv/src/commands/tool/run.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ use std::path::Path;
use std::path::PathBuf;
use std::str::FromStr;

use anstream::eprint;
use anyhow::{Context, bail};
use console::Term;
use itertools::Itertools;
Expand Down Expand Up @@ -55,7 +54,9 @@ use crate::commands::project::{
use crate::commands::reporters::PythonDownloadReporter;
use crate::commands::tool::common::{ToolPython, matching_packages, refine_interpreter};
use crate::commands::tool::{Target, ToolRequest};
use crate::commands::{diagnostics, project::environment::CachedEnvironment, read_env_files};
use crate::commands::{
UvError, diagnostics, project::environment::CachedEnvironment, read_env_files,
};
use crate::printer::Printer;
use crate::settings::ResolverInstallerSettings;
use crate::settings::ResolverSettings;
Expand Down Expand Up @@ -301,10 +302,8 @@ pub(crate) async fn run(
}

Err(ProjectError::Requirements(err)) => {
let err = miette::Report::msg(format!("{err}"))
.context("Failed to resolve `--with` requirement");
eprint!("{err:?}");
return Ok(ExitStatus::Failure);
let err = anyhow::Error::new(err).context("Failed to resolve `--with` requirement");
return Err(UvError::user(err).into());
}
Err(err) => return Err(err.into()),
};
Expand Down
17 changes: 12 additions & 5 deletions crates/uv/tests/tool/tool_run.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1910,7 +1910,16 @@ fn tool_run_with_editable() -> anyhow::Result<()> {
+ werkzeug==3.0.1
");

// If invalid, we should reference `--with`.
Ok(())
}

/// Invalid `--with` requirements should use the standard user-error renderer.
#[test]
fn tool_run_invalid_with() {
let context = uv_test::test_context!("3.12");
let tool_dir = context.temp_dir.child("tools");
let bin_dir = context.temp_dir.child("bin");

uv_snapshot!(context.filters(), context
.tool_run()
.arg("--with")
Expand All @@ -1924,11 +1933,9 @@ fn tool_run_with_editable() -> anyhow::Result<()> {
----- stdout -----

----- stderr -----
× Failed to resolve `--with` requirement
╰─▶ Distribution not found at: file://[TEMP_DIR]/foo
error: Failed to resolve `--with` requirement
Caused by: Distribution not found at: file://[TEMP_DIR]/foo
");

Ok(())
}

#[test]
Expand Down
Loading