Avoid repeated workspace-member lookups during discovery#281
Draft
zaniebot wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated cached workspace discovery scans every workspace member to recover the package name for each member path. Commands that discover many members in a wide workspace therefore do quadratic path-comparison work even though the workspace cache is already keyed by those paths.
Cache each workspace member's name with its path, preserving the discovery behavior established in uv#18311 and uv#20363.
Performance
An optimized, CPU-pinned Namespace size sweep (x86_64 AMD EPYC, 16 vCPU, Rust 1.96.1; median of three runs) uses equally sized member and lookup sets. The indexed result includes building the path index.