This repository was archived by the owner on Dec 16, 2025. It is now read-only.
Remove explicit ethers version set#1763
Merged
michaelkaplan13 merged 4 commits intoSep 30, 2025
Merged
Conversation
ethers version set
alarso16
approved these changes
Sep 30, 2025
Contributor
|
Should we be pinning these to a specific version (by removing the "^") instead? I'm not super familiar with NPM, but explicitly setting the version seems less error prone than letting it be determined by dependencies. |
Contributor
Touched base offline. Explicitly pinning to a specific version also appears to break the tests in other ways. I'm fine with going with this for now since the plan is to remove NPM in favor or Foundry in the near term anyways. |
michaelkaplan13
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
@alarso16 and I are suspicious that this package version set led to flakiness present lately in the
e2e-precompiletest. Removing this still results in a clean audit, and passing test suites, and we instead led the declared versions for packages decide what version of ethers to use.How this was tested
Existing UTs
Need to be documented?
No
Need to update RELEASES.md?
No