This repository was archived by the owner on Dec 16, 2025. It is now read-only.
sync: coreth PR #1305: feat!: explicit libevm calls to Register{Extras,Hooks}()#1773
Merged
Conversation
vm.RegisterExtras()libevm calls to Register{Extras,Hooks}()
libevm calls to Register{Extras,Hooks}()libevm calls to Register{Extras,Hooks}()
powerslider
approved these changes
Oct 6, 2025
ceyonur
reviewed
Oct 6, 2025
| // RegisterAllLibEVMExtras is a convenience wrapper for calling | ||
| // [core.RegisterExtras], [customtypes.Register], and [params.RegisterExtras]. | ||
| // Together these are necessary and sufficient for configuring libevm for | ||
| // C-Chain behaviour. |
Collaborator
There was a problem hiding this comment.
nit: subnet-evm
Suggested change
| // C-Chain behaviour. | |
| // Subnet-EVM behaviour. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a port of ava-labs/coreth#1305
Why this should be merged
Allow imports of both
corethandsubnet-evmwithout panic due to re-registration oflibevmextras.How this works
Makes registration explicit instead of in
init()or in declaration of global variables.This MUST be done in, and only in, tests and
package main. For more background on the rationale, see the Google Go style guide re underscore imports for side effects, which have a similar effect.How this was tested
Existing tests.
Need to be documented?
Yes
Need to update RELEASES.md?
Yes