Skip to content
This repository was archived by the owner on Dec 16, 2025. It is now read-only.

sync: coreth PR #1234: ACP-226: Add MinDelayExcess to header#1788

Merged
ceyonur merged 4 commits into
masterfrom
ceyonur/sync-coreth-1234
Oct 8, 2025
Merged

sync: coreth PR #1234: ACP-226: Add MinDelayExcess to header#1788
ceyonur merged 4 commits into
masterfrom
ceyonur/sync-coreth-1234

Conversation

@ceyonur

@ceyonur ceyonur commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

@ceyonur ceyonur force-pushed the ceyonur/sync-coreth-1234 branch from 9f3fe3e to 0dcbb1a Compare October 8, 2025 08:30
@ceyonur ceyonur marked this pull request as ready for review October 8, 2025 11:33
@ceyonur ceyonur requested a review from a team as a code owner October 8, 2025 11:33
Comment thread core/genesis.go Outdated
Comment thread plugin/evm/customtypes/block_ext.go Outdated
Comment thread plugin/evm/customtypes/header_ext.go Outdated
Comment thread plugin/evm/customtypes/header_ext_test.go
ceyonur and others added 2 commits October 8, 2025 17:38
Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com>
Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com>
@JonathanOppenheimer JonathanOppenheimer changed the title ACP-226: Add MinDelayExcess to header (#1234) sync: coreth PR #1234: ACP-226: Add MinDelayExcess to header Oct 8, 2025

@JonathanOppenheimer JonathanOppenheimer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should try to avoid making additional changes on the sync PR unless the changes are specific to subnet-evm. We should sync the changes Arran made to this PR back to the coreth PR. Otherwise LGTM.

@ceyonur ceyonur added this pull request to the merge queue Oct 8, 2025
Merged via the queue into master with commit 9af16ac Oct 8, 2025
13 checks passed
@ceyonur ceyonur deleted the ceyonur/sync-coreth-1234 branch October 8, 2025 16:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants