perf: Fix performance regression for generator#17627
Closed
liuxingbaoyu wants to merge 2 commits into
Closed
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/60353 |
Member
Author
|
|
|
commit: |
Member
Author
|
It has been replaced by #17642. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2This fixes the performance regression from
v7.26.3tov7.26.5.There is 10% performance improvement.
I've tried many methods, but none have been able to fix the performance regression based on the original logic.
These include using
Object.assignonce, and building a new object in the sorted order, etc.I don't understand why the performance of methods exported from modules and methods in objects is still different even when we add them to the class prototype.