Skip to content

[ENH] add BEP 0XX - Cardiac MRI#613

Draft
Remi-Gau wants to merge 10 commits into
mainfrom
enh/bep_045
Draft

[ENH] add BEP 0XX - Cardiac MRI#613
Remi-Gau wants to merge 10 commits into
mainfrom
enh/bep_045

Conversation

@Remi-Gau

@Remi-Gau Remi-Gau commented Feb 4, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@Remi-Gau

Remi-Gau commented Feb 4, 2025

Copy link
Copy Markdown
Contributor Author

@christinerogers this cannot be merged unless a link to the google doc is provided

@Remi-Gau

Remi-Gau commented Feb 4, 2025

Copy link
Copy Markdown
Contributor Author

Also this is going to require some update of the list of contributors in the spec:

045 Cardiac MRI (CMR)
NOT FOUND Edward Xu
FOUND Jefferson Casimir
FOUND Ghislain Vaillant
no email in specification/CITATION.cff.

Comment thread data/beps/beps.yml
@christinerogers

Copy link
Copy Markdown
Contributor

this follows on from #611 #612

@effigies

Copy link
Copy Markdown
Contributor

#618 has a BEP 045 already ready to go. Should we renumber this one to 046 while we wait for it?

@christinerogers

christinerogers commented Feb 17, 2025

Copy link
Copy Markdown
Contributor

#618 has a BEP 045 already ready to go. Should we renumber this one to 046 while we wait for it?

sure, i've renamed it to 046 everywhere, added the googledoc (now open) and invited Ghislain .

cc @Remi-Gau - ready for your review

@christinerogers christinerogers changed the title [ENH] add BEP 045 [ENH] add BEP 046 Feb 17, 2025
Comment thread data/beps/beps.yml Outdated
@christinerogers

Copy link
Copy Markdown
Contributor

Also this is going to require some update of the list of contributors in the spec:

045 Cardiac MRI (CMR) NOT FOUND Edward Xu FOUND Jefferson Casimir FOUND Ghislain Vaillant no email in specification/CITATION.cff.

@Remi-Gau I think i've addressed all of this including an email in the beps.yml
not sure if i need to make further changes to resolve the Citation.cff issue?

@christinerogers christinerogers changed the title [ENH] add BEP 046 [ENH] add BEP 046- Cardiac MRI Feb 20, 2025
Remi-Gau and others added 5 commits March 6, 2025 13:31
Co-authored-by: Remi Gau <remi_gau@hotmail.com>
this branch should be renamed too but oh well
adding email, fixing names
@christinerogers

Copy link
Copy Markdown
Contributor

thanks @effigies No merge for now, pending further discussion

Comment thread data/beps/beps.yml Outdated
@effigies effigies marked this pull request as draft May 30, 2025 18:56
@effigies effigies changed the title [ENH] add BEP 046- Cardiac MRI [ENH] add BEP 0XX - Cardiac MRI May 30, 2025
@effigies

Copy link
Copy Markdown
Contributor

Converting to draft and freeing up BEP46.

Comment thread data/beps/beps.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants