• utils: Use _wfopen and _wfreopen on Windows #13866 (utils: Use _wfopen and _wreopen on Windows by ken2812221)
• utils: drop boost::interprocess::file_lock #13862 (utils: drop boost::interprocess::file_lock by ken2812221)
• Move src/tinyformat.h to src/tinyformat/tinyformat.h #13846 (Move src/tinyformat.h to src/tinyformat/tinyformat.h by Empact)
• Include tinyformat as a subtree #13845 (Include tinyformat as a subtree by Empact)
• [wallet] Kill accounts #13825 ([wallet] [Do not merge until v0.18] Kill accounts by jnewbery)
• Test for Windows encoding issue #13787 (Test for [bugfix] Fix encoding issue for Windows #13426 by ken2812221)
• PSBT key path cleanups #13723 (PSBT key path cleanups by sipa)
• Remove the boost/algorithm/string/case_conv.hpp dependency #13671 (Remove the boost/algorithm/string/case_conv.hpp dependency by 251Labs)
• [bugfix] Fix encoding issue for Windows #13426 ([bugfix] Fix encoding issue for Windows by ken2812221)
• Thread names in logs and deadlock debug tools (take 2) #13168 (Thread names in logs and deadlock debug tools (take 2) by jamesob)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

utACK e00407dbbd13ccb8fd789811b4fee6871f737f9e

I'm not sure this is a good idea.
I kind of liked having separate, specialized functions for this.
These currently happen to be implemented in terms of strprintf, but this is not necessary and has relatively high overhead.
(originally these were implemented using the appropriate C functions, but this was changed due to locale-dependence concerns)

So tend toward NACK.

I checked for cases in need of optimization and don't really see them. Here are some numbers which show about an order of magnitude of variance: http://www.zverovich.net/2013/09/07/integer-to-string-conversion-in-cplusplus.html fmt seems to have the fastest implementation according to these: http://www.zverovich.net/2013/09/07/integer-to-string-conversion-in-cplusplus.html https://github.com/fmtlib/fmt#speed-tests but I doubt it's worthwhile to bring that in.

Looking into that led me to inlining WriteOrderPos and correcting the format string to be unsigned for ccode and nTransactionsUpdatedLast.

I'm tending towards a Nack for this too unfort.

Looking into that led me to inlining WriteOrderPos and correcting the format string to be unsigned for ccode and nTransactionsUpdatedLast.

When yous say inlining, you mean in the code but the function is inlined anyway so run time it won't have a performance impact. I like the functions since they document the code. It's easier to read :-)

Thanks for the look! Closing due to NACKs.