build: generate MSVC project files via python script#14062
Conversation
Note to reviewers: This pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Concept ACK This is excellent! I think auto-generation is the only practical way to solve this for the reasons you listed. Can we test it against recent PR:s that broke appveyor due to files being added/removed to verify that this would have solved those cases? |
There was a problem hiding this comment.
Nit: Missing whitespace around =.
The flake8 rule set enforced by Travis is a bit lax, but since this is brand new code I suggest following all the advice given by flake8 to avoid any Python style nits :-)
$ flake8 --ignore=E501 msvc-autogen.py # E501: line length
msvc-autogen.py:6:11: E225 missing whitespace around operator
msvc-autogen.py:27:1: E302 expected 2 blank lines, found 1
msvc-autogen.py:29:20: E225 missing whitespace around operator
msvc-autogen.py:33:79: E713 test for membership should be 'not in'
msvc-autogen.py:36:32: E225 missing whitespace around operator
msvc-autogen.py:39:39: E231 missing whitespace after ','
msvc-autogen.py:41:32: E225 missing whitespace around operator
msvc-autogen.py:45:1: E302 expected 2 blank lines, found 1
msvc-autogen.py:58:1: E305 expected 2 blank lines after class or function definition, found 1
|
utACK 0b16f67 A minor style nit: Personally I prefer string construction via “new style” |
|
Now the master branch has failed while this PR is success. |
|
utACK 0b16f67 |
0b16f67 auto generate MSVC project files (Chun Kuan Lee) Pull request description: The reason that I move from original `*.vcxproj` to template `*.vcxproj.in` file: - There are many developers does not know how to edit .vcxproj file - To keep consistency, don't need to edit file at two different places Now the devs do not have to update two seperate files. Tree-SHA512: ab06dbec588cab57f16c1993ea80ed25a49b0b129884634512a8bcd8a21a1a55d38636922489bcf9120d504cfc2cbe4d2b888a217c4e65a50555b41fcd3b7004
|
thanks for doing this, post-mortem ACK |
|
@ken2812221 would you mind if I make a PR replacing |
|
@NicolasDorier You need python anyway for the tests |
|
Indeed. I was under the impression the python tests were still linux only. |
|
@NicolasDorier I am just working on #14007, the functional tests is available on Windows in the PR.
I'll try, but I am not familiar with powershell. |
| 'libbitcoin_zmq', | ||
| ] | ||
|
|
||
| ignore_list = [ |
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks, that's a pretty good improvement. would allow 2 cpp files with same filename.
The reason that I move from original
*.vcxprojto template*.vcxproj.infile:Now the devs do not have to update two seperate files.