test: Extend stale tip test by maflcko · Pull Request #18470 · bitcoin/bitcoin

maflcko · 2020-03-30T11:45:59Z

Extend test with ASSERT_DEBUG_LOG
Extend test with case where a block is in flight from a node that is
about to be evicted

DrahtBot · 2020-03-30T12:27:45Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
Concept ACK	jonatack, fanquake, practicalswift
Stale ACK	fridokus

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#27385 (net, refactor: extract Network and BIP155Network logic to node/network by jonatack)
#27213 (p2p: Diversify automatic outbound connections with respect to networks by amitiuttarwar)
#25908 (p2p: remove adjusted time by fanquake)
#25572 (refactor: Introduce EvictionManager and use it for the inbound eviction logic by dergoegge)
#25268 (refactor: Introduce EvictionManager by dergoegge)
#23352 (test: Extend stale_tip_peer_management test by MarcoFalke)
#17860 (fuzz: BIP 42, BIP 30, CVE-2018-17144 by MarcoFalke)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Coverage

Coverage	Change (pull 18470, 333634883d442ef0a9bd57e399f4cc97003e624f)	Reference (master, `5f9cd62`)
Lines	+0.0553 %	90.2454 %
Functions	+0.2530 %	85.9695 %
Branches	-0.0140 %	51.7670 %

^{Updated at: 2020-03-30T13:59:49.217418.}

fridokus · 2020-03-30T13:32:24Z

ACK faaba842d03762591f8612fd1fb16c93c881913f
Ran functional tests on Ubuntu 16 and glanced through the code.

fridokus · 2020-03-31T12:22:07Z

ACK fadb1acd1392d42b08d5b27360764c83e94b42ae
Ran functional tests.

jonatack · 2020-05-05T21:27:20Z

Concept ACK to be notified on rebase.

fanquake

Concept ACK

faa01d6 and faee067 look good.

As for fa579ee; +1 for moving to std::chrono. However there seems to be some unrelated changes bundled into this commit. Didn't look at the test changes too hard.

fanquake · 2020-05-27T10:49:41Z

    LOCK(cs_main);
    CNodeState *state = State(node);
    if (state) state->m_last_block_announcement = time_in_seconds;
+    if (state) state->fHaveWitness = true;


This seems unrelated to std::chrono:: / time refactoring.

fanquake · 2021-06-09T12:52:21Z

@MarcoFalke could you rebase this (if there isn't any other PR that should be reviewed first), and comment in regards to: #18470 (comment).

…n denialofservice_tests fa72fce test: Use ConnmanTestMsg from test lib in denialofservice_tests (MarcoFalke) Pull request description: This allows to remove code. Also, required for bitcoin/bitcoin#18470 ACKs for top commit: mjdietzx: crACK fa72fce 👍👍 fanquake: ACK fa72fce Tree-SHA512: 12aa68cde697c0f7c25d60bb0c02783e5462eb3ba39947b0d94a7798bc278e7d5f092f3ab2a3d0547947c3502cde7c4a599419055a57f78ef1f70f9f637e14c7

achow101 · 2022-10-12T18:06:24Z

Are you still working on this?

* Extend test with ASSERT_DEBUG_LOG * Extend test with case where a block is in flight from a node that is about to be evicted

DrahtBot · 2023-05-06T11:56:20Z

🐙 This pull request conflicts with the target branch and needs rebase.

DrahtBot · 2023-08-04T01:42:35Z

There hasn't been much activity lately and the patch still needs rebase. What is the status here?

Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
Is it no longer relevant? ➡️ Please close.
Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

furszy

This test extension could play well with #28170. Are you planning to rebase it? Happy to review it.

achow101 · 2023-09-23T16:44:26Z

Closing as up for grabs due to lack of activity.

…ofservice_tests fa72fce test: Use ConnmanTestMsg from test lib in denialofservice_tests (MarcoFalke) Pull request description: This allows to remove code. Also, required for bitcoin#18470 ACKs for top commit: mjdietzx: crACK fa72fce 👍👍 fanquake: ACK fa72fce Tree-SHA512: 12aa68cde697c0f7c25d60bb0c02783e5462eb3ba39947b0d94a7798bc278e7d5f092f3ab2a3d0547947c3502cde7c4a599419055a57f78ef1f70f9f637e14c7

maflcko added the P2P label Mar 30, 2020

DrahtBot mentioned this pull request Mar 30, 2020

P2P: Mempool tracks locally submitted transactions to improve wallet privacy #18038

Merged

maflcko force-pushed the 2003-testEviction branch 2 times, most recently from fa80a67 to fa53539 Compare March 30, 2020 14:41

DrahtBot mentioned this pull request Mar 30, 2020

Return BlockValidationState from ProcessNewBlock if CheckBlock/AcceptBlock fails #17479

Closed

maflcko force-pushed the 2003-testEviction branch from fa53539 to fadb1ac Compare March 30, 2020 16:13

DrahtBot mentioned this pull request Apr 4, 2020

fuzz: Add process_messages harness #18521

Merged

DrahtBot added the Needs rebase label Apr 8, 2020

maflcko force-pushed the 2003-testEviction branch 2 times, most recently from fa76ba8 to fa579ee Compare April 8, 2020 17:43

DrahtBot removed the Needs rebase label Apr 8, 2020

This was referenced Apr 9, 2020

fuzz: Disable debug log file #18571

Merged

assumeutxo #15606

Closed

DrahtBot added the Needs rebase label Apr 15, 2020

fanquake reviewed May 27, 2020

View reviewed changes

maflcko force-pushed the 2003-testEviction branch 2 times, most recently from fa70eae to fa9a78c Compare June 9, 2021 19:18

maflcko added the Waiting for author label Jun 9, 2021

maflcko mentioned this pull request Jun 9, 2021

test: Use ConnmanTestMsg from test lib in denialofservice_tests #22203

Merged

DrahtBot removed the Needs rebase label Jun 9, 2021

This was referenced Jun 10, 2021

Make all networking code mockable #21878

Closed

[net processing] Various tidying up of PeerManagerImpl ctor #21562

Merged

banman: save the banlist in a JSON format on disk #20966

Merged

maflcko force-pushed the 2003-testEviction branch from fa9a78c to 90b5776 Compare June 11, 2021 06:25

net: Extend stale tip test

faac87d

* Extend test with ASSERT_DEBUG_LOG * Extend test with case where a block is in flight from a node that is about to be evicted

maflcko force-pushed the 2003-testEviction branch from 5a93df5 to faac87d Compare January 11, 2023 11:49

DrahtBot removed the Needs rebase label Jan 11, 2023

DrahtBot mentioned this pull request Jan 14, 2023

BIP324: Enable v2 P2P encrypted transport #24545

Closed

DrahtBot mentioned this pull request Jan 24, 2023

refactor: Introduce EvictionManager #25268

Closed

DrahtBot mentioned this pull request Feb 7, 2023

test/BIP324: functional tests for v2 P2P encryption #24748

Merged

DrahtBot mentioned this pull request Mar 6, 2023

p2p: Diversify automatic outbound connections with respect to networks #27213

Merged

DrahtBot mentioned this pull request Apr 1, 2023

net, refactor: extract Network and BIP155Network logic to node/network #27385

Closed

DrahtBot added the Needs rebase label May 6, 2023

furszy reviewed Aug 4, 2023

View reviewed changes

achow101 added the Up for grabs label Sep 23, 2023

achow101 closed this Sep 23, 2023

maflcko removed the Up for grabs label Feb 6, 2024

maflcko deleted the 2003-testEviction branch February 6, 2024 10:43

bitcoin locked and limited conversation to collaborators Feb 5, 2025

Uh oh!

Conversation

maflcko commented Mar 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Mar 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews

Conflicts

Coverage

Uh oh!

fridokus commented Mar 30, 2020

Uh oh!

fridokus commented Mar 31, 2020

Uh oh!

jonatack commented May 5, 2020

Uh oh!

fanquake left a comment

Choose a reason for hiding this comment

Uh oh!

fanquake May 27, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fanquake commented Jun 9, 2021

Uh oh!

achow101 commented Oct 12, 2022

Uh oh!

DrahtBot commented May 6, 2023

Uh oh!

DrahtBot commented Aug 4, 2023

Uh oh!

furszy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

achow101 commented Sep 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

maflcko commented Mar 30, 2020 •

edited

Loading

DrahtBot commented Mar 30, 2020 •

edited

Loading

furszy left a comment •

edited

Loading