Skip to content

Make all networking code mockable #21878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vasild wants to merge 9 commits into from
Closed

Make all networking code mockable #21878

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1a23f0c
i2p: avoid using Sock::Get() for checking for a valid socket
vasild May 25, 2021
f5c5783
net: don't check if the socket is valid in GetBindAddress()
vasild May 25, 2021
7426958
net: don't check if the socket is valid in ConnectSocketDirectly()
vasild May 25, 2021
b740d39
net: remove now unnecessary Sock::Get()
vasild Apr 29, 2021
2bcbe87
net: remove Sock default constructor, it's not necessary
vasild May 28, 2021
618b3ec
fuzz: add CConnman::OpenNetworkConnection() to the tests
vasild Apr 15, 2021
1545b55
fuzz: add CConnman::CreateNodeFromAcceptedSocket() to the tests
vasild Apr 15, 2021
bb98574
fuzz: add CConnman::InitBinds() to the tests
vasild Apr 15, 2021
80d9dfd
fuzz: add CConnman::SocketHandler() to the tests
vasild Apr 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fuzz: add CConnman::CreateNodeFromAcceptedSocket() to the tests
  • Loading branch information
@vasild
vasild committed Aug 16, 2023
commit 1545b555175be1f095bdedd00ff4545db3693371
12 changes: 12 additions & 0 deletions src/test/fuzz/connman.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
#include <util/translation.h>

#include <cstdint>
#include <memory>
#include <vector>

namespace {
Expand Down Expand Up @@ -158,6 +159,17 @@ FUZZ_TARGET(connman, .init = initialize_connman)
}

connman.OpenNetworkConnection(to_addr, count_failure, grant_ptr, to_str, conn_type);
},
[&] {
connman.SetNetworkActive(true);

NetPermissionFlags permissions{
ConsumeWeakEnum(fuzzed_data_provider, ALL_NET_PERMISSION_FLAGS)};
auto me = ConsumeAddress(fuzzed_data_provider);
auto peer = ConsumeAddress(fuzzed_data_provider);
auto sock = CreateSock(peer);

connman.CreateNodeFromAcceptedSocketPublic(std::move(sock), permissions, me, peer);
});
}
(void)connman.GetAddedNodeInfo();
Expand Down
8 changes: 8 additions & 0 deletions src/test/util/net.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,14 @@ struct ConnmanTestMsg : public CConnman {
m_nodes.clear();
}

void CreateNodeFromAcceptedSocketPublic(std::unique_ptr<Sock> sock,
NetPermissionFlags permissions,
const CAddress& addr_bind,
const CAddress& addr_peer)
{
CreateNodeFromAcceptedSocket(std::move(sock), permissions, addr_bind, addr_peer);
}

void Handshake(CNode& node,
bool successfully_connected,
ServiceFlags remote_services,
Expand Down