Skip to content

policy: nVersion=3 and Package RBF #25038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
glozow wants to merge 15 commits into from
Closed

policy: nVersion=3 and Package RBF #25038

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3bca679
[mempool] evict everything paying 0 fees in TrimToSize()
glozow Nov 10, 2023
18406ec
[policy] policy rules for nVersion=3
glozow Jul 5, 2022
1b2cd22
[policy] allow V3 transactions under certain conditions
glozow Jul 5, 2022
c74c826
[policy] allow individual v3 txns to be below min relay feerate
glozow Jan 17, 2023
3ad3ea5
[test framework] parameterize version in create_self_transfer
glozow Aug 31, 2022
b828ea0
[functional test] v3 transaction submission
glozow Aug 31, 2022
f82c9fd
[doc] v3 policy
glozow Apr 29, 2022
d6bd8dc
[doc] cpfp carveout is excluded in packages
glozow Nov 3, 2022
75a1efd
[refactor] make some members MemPoolAccept-wide
glozow Aug 3, 2021
25f528a
[policy] check whether replacement is more incentive compatible
glozow Jul 5, 2022
0933d4f
[refactor] rename entries to be more descriptive
glozow Nov 2, 2022
d629f29
[unit test] for CheckAncestorScores
glozow Sep 28, 2021
4785582
[packages/policy] implement package RBF for v3 transactions
glozow Aug 3, 2021
678f56d
[test util] CreateValidMempoolTransaction version parameter, always s…
glozow Nov 28, 2022
0bc6375
[test] package rbf
glozow Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[unit test] for CheckAncestorScores
  • Loading branch information
@glozow
glozow committed Nov 27, 2023
commit d629f29fc8e740a6ce40da97436246f2abe3467b
54 changes: 54 additions & 0 deletions src/test/rbf_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ BOOST_FIXTURE_TEST_CASE(rbf_helper_functions, TestChain100Setup)
CTxMemPool::setEntries set_12_normal{entry1_normal, entry2_normal};
CTxMemPool::setEntries set_34_cpfp{entry3_low, entry4_high};
CTxMemPool::setEntries set_56_low{entry5_low, entry6_low_prioritised};
CTxMemPool::setEntries set_78_high{entry7_high, entry8_high};
CTxMemPool::setEntries all_entries{entry1_normal, entry2_normal, entry3_low, entry4_high,
entry5_low, entry6_low_prioritised, entry7_high, entry8_high};
CTxMemPool::setEntries empty_set;
Expand Down Expand Up @@ -228,6 +229,59 @@ BOOST_FIXTURE_TEST_CASE(rbf_helper_functions, TestChain100Setup)
const auto spends_conflicting_confirmed = make_tx({m_coinbase_txns[0], m_coinbase_txns[1]}, {45 * CENT});
BOOST_CHECK(HasNoNewUnconfirmed(*spends_conflicting_confirmed.get(), pool, {entry1_normal, entry3_low}) == std::nullopt);

// Tests for CheckMinerScores
// Don't allow replacements with a low ancestor feerate.
BOOST_CHECK(CheckMinerScores(/*replacement_fees=*/entry1_normal->GetFee(),
/*replacement_vsize=*/entry1_normal->GetTxSize(),
/*ancestors=*/{entry5_low},
/*direct_conflicts=*/{entry1_normal},
/*original_transactions=*/set_12_normal).has_value());

BOOST_CHECK(CheckMinerScores(entry3_low->GetFee() + entry4_high->GetFee() + 10000,
entry3_low->GetTxSize() + entry4_high->GetTxSize(),
{entry5_low},
{entry3_low},
set_34_cpfp).has_value());

// These tests use modified fees (including prioritisation), not base fees.
BOOST_CHECK(CheckMinerScores(entry5_low->GetFee() + entry6_low_prioritised->GetFee() + 1,
entry5_low->GetTxSize() + entry6_low_prioritised->GetTxSize(),
{empty_set},
{entry5_low},
set_56_low).has_value());
BOOST_CHECK(CheckMinerScores(entry5_low->GetModifiedFee() + entry6_low_prioritised->GetModifiedFee() + 1,
entry5_low->GetTxSize() + entry6_low_prioritised->GetTxSize(),
{empty_set},
{entry5_low},
set_56_low) == std::nullopt);

// High-feerate ancestors don't help raise the replacement's miner score.
BOOST_CHECK(CheckMinerScores(entry1_normal->GetFee() - 1,
entry1_normal->GetTxSize(),
empty_set,
set_12_normal,
set_12_normal).has_value());

BOOST_CHECK(CheckMinerScores(entry1_normal->GetFee() - 1,
entry1_normal->GetTxSize(),
set_78_high,
set_12_normal,
set_12_normal).has_value());

// Replacement must be higher than the individual feerate of direct conflicts.
// Note entry4_high's individual feerate is higher than its ancestor feerate
BOOST_CHECK(CheckMinerScores(entry4_high->GetFee() - 1,
entry4_high->GetTxSize(),
empty_set,
{entry4_high},
{entry4_high}).has_value());

BOOST_CHECK(CheckMinerScores(entry4_high->GetFee() - 1,
entry4_high->GetTxSize(),
empty_set,
{entry3_low},
set_34_cpfp) == std::nullopt);

}

BOOST_AUTO_TEST_SUITE_END()