Fix typos#28605
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
There was a problem hiding this comment.
This is a reference to a Github repo in the Guix install doc.
|
Updated to also fix |
|
Dropped typo fix in |
|
This is a nice idea. I always have a conflict between submitting this simple typo-fixing PRs and ignoring them. This should be done often, for evey release .
|
Why not bumping the codespell version in CI simultaneously? |
There was a problem hiding this comment.
I reckon that changes in such a pull request should be forced by a linter. However, with the picked change into the spelling.ignore-words.txt file, the linter output is as follows:
$ ./test/lint/lint-spelling.py
src/addrman.h:175: occurence ==> occurrence
src/net_processing.cpp:2450: annnounced ==> announced
src/net_processing.cpp:3595: succesful ==> successful
src/policy/policy.h:101: compatability ==> compatibility
src/qt/transactiontablemodel.cpp:222: re-use ==> reuse
src/rpc/server.cpp:412: unspecifed ==> unspecified
src/rpc/util.cpp:1091: re-use ==> reuse
src/rpc/util.h:409: documention ==> documentation
src/test/fuzz/FuzzedDataProvider.h:161: capaticity ==> capacity
src/test/orphanage_tests.cpp:114: Re-use ==> Reuse
src/test/script_tests.cpp:1115: re-use ==> reuse
src/torcontrol.cpp:254: implementors ==> implementers
src/txmempool.h:480: appplies ==> applies
src/wallet/feebumper.cpp:173: re-use ==> reuse
src/wallet/spend.cpp:1260: re-use ==> reuse
src/wallet/spend.cpp:1302: Re-use ==> Reuse
test/functional/test_framework/blockfilter.py:32: relvant ==> relevant
test/functional/wallet_avoidreuse.py:260: re-use ==> reuse
^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.ignore-words.txt
Apparently, the linter ignores the word "re-used" in the following files:
ci/README.mddepends/description.mdsrc/test/versionbits_tests.cppsrc/wallet/wallet.h
The overall changes look consistent though.
ACK 650e22d65bd3504f51547f4d70d6d74101ff602f.
I'll look into that if I have to retouch. At least we know that such a bump won't reveal new typos, so it can be done safely anytime. |
jarolrod
left a comment
There was a problem hiding this comment.
ACK 650e22d65bd3504f51547f4d70d6d74101ff602f
hernanmarino
left a comment
There was a problem hiding this comment.
ACK 650e22d65bd3504f51547f4d70d6d74101ff602f
pablomartin4btc
left a comment
There was a problem hiding this comment.
ACK 650e22d65bd3504f51547f4d70d6d74101ff602f
There was a problem hiding this comment.
Actually, both implementors & implementers are valid words, but it seems they have different meaning (Implementer: One who has implemented, Implementor: One who provides implementation).
|
ACK 650e22d65bd3504f51547f4d70d6d74101ff602f |
|
NACK on adding this to the release process. I don't understand why the CI infra isn't being changed here. This is the wrong solution to a non-problem. |
|
To clarify:
We aren't changing consensus code here, why would it be unsafe to fix typos at any time? |
|
Also a NACK on adding this to the release process. We should be looking for ways to reduce manual steps and further automate the release process. The last commit adds a manual step and doesn't address the root cause of how these spelling errors are getting merged in the first place. I'd suggest we drop 650e22d and instead, look into updating the linting infrastructure so that these errors are caught going forward. If after fixing the linting infrastructure we still need manual fix up PRs, they should happen whenever someone is sufficiently motivated to do it, and not be tied to a release process. Ideally, any future fix-up PRs should also include updates to the linting infrastructure to prevent the same type of errors from sneaking through. |
|
ACK e062212 |
|
Are you still working on this? Otherwise, I think it can be closed, so that it can be picked up by someone else, if it is still relevant. |
|
I was still waiting for feedback from maintainers, but I'll just drop the last commit. |
test/functional/feature_assumeutxo.py:78: refering ==> referring
test/functional/feature_assumeutxo.py:115: refering ==> referring
^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.ignore-words.txt |
DrahtBot has a summary comment, which has links to all feedback, including that of maintainers, see #28605 (comment) |
As found by lint-spelling.py using codespell 2.2.6.
|
Rebased to fix those two new typos. |
|
There are even more since this was last updated, but going to merge this now, and we can follow up again later. |
This PR fixes typos found by lint-spelling.py using codespell 2.2.6.
Our CI linter job uses codespell 2.2.5 and found fewer typos that I did locally. In any case it's happy now.