Skip to content

[28.x] Backports#32811

Merged
fanquake merged 5 commits into
bitcoin:28.xfrom
fanquake:28_more_backporting
Jul 3, 2025
Merged

[28.x] Backports#32811
fanquake merged 5 commits into
bitcoin:28.xfrom
fanquake:28_more_backporting

Conversation

@fanquake

@fanquake fanquake commented Jun 25, 2025

Copy link
Copy Markdown
Member

@fanquake fanquake added this to the 28.3 milestone Jun 25, 2025
@DrahtBot

DrahtBot commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32811.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

willcl-ark and others added 2 commits June 27, 2025 15:06
Current behaviour will by-default use SOURCE_DATE_EPOCH from the
environment without warning. This breaks the default reproducibility
from a guix build.

Warn when and exit when this variable is set, and
FORCE_SOURCE_DATE_EPOCH is unset.

Github-Pull: bitcoin#32678
Rebased-From: 5c4a0f8
@fanquake fanquake force-pushed the 28_more_backporting branch from 6a203f7 to 44b07b2 Compare June 27, 2025 14:07
@fanquake fanquake marked this pull request as ready for review July 2, 2025 12:24
@fanquake fanquake requested review from hebasto and willcl-ark July 2, 2025 12:24

@hebasto hebasto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 44b07b2.

@fanquake fanquake merged commit 3c56d36 into bitcoin:28.x Jul 3, 2025
15 of 16 checks passed
@fanquake fanquake deleted the 28_more_backporting branch July 3, 2025 16:36
morozow pushed a commit to morozow/bitcoin_rd that referenced this pull request May 8, 2026
38d20b2 doc: update release notes for 28.x (fanquake)
1ec159d guix: warn and abort when SOURCE_DATE_EPOCH is set (will)
428e9d2 doc: taproot became always active in v24.0 (Sjors Provoost)
01ff9f4 doc: fix transifex 404s (fanquake)
0d2c75c test: Fix list index out of range error in feature_bip68_sequence.py (zaidmstrr)

Pull request description:

  Backports:
  * bitcoin#32678
  * bitcoin#32765
  * bitcoin#32776
  * bitcoin#32777

ACKs for top commit:
  hebasto:
    ACK 38d20b2.

Tree-SHA512: 01a3987e222622c16583dae91b1efe4428110ff2d852da13ca34ba3270d40e678dd41d3ec53b89bda260efda706e89f4ee2c1c8bb6cc0d157e5145de001f5526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants