[29.x] backport #33212#33251
Merged
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33251. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
Member
|
Can you add the GitHub-Pull / Rebased-From metadata to each commit. |
The committed state of an index should never be ahead of the flushed chainstate. Otherwise, in the case of an unclean shutdown, the blocks necessary to revert from the prematurely committed state would not be available, which would corrupt the coinstatsindex in particular. Instead, the index state will be committed with the next ChainStateFlushed notification. Github-Pull: bitcoin#33212 Rebased-From: 01b95ac
This test fails without the previous commit. Github-Pull: bitcoin#33212 Rebased-From: a602f6f
8f06292 to
fcac802
Compare
Contributor
Author
done |
stickies-v
approved these changes
Aug 26, 2025
stickies-v
left a comment
Contributor
There was a problem hiding this comment.
ACK fcac802
There have been quite substantial changes to BaseIndex::Rewind() in 6f1392c that might warrant extra careful review, even though I couldn't find any issues.
The rationale and mechanics from the original PR all still hold here, and the changes look correct to me. The backport commits are clean, and the added test in fcac802 still fails without the fix in 16b1710.
Member
|
cc @mzumsande |
Member
|
ACK fcac802 |
Merged
glozow
added a commit
that referenced
this pull request
Sep 3, 2025
084c95a doc: update manual pages for v29.1 (fanquake) 37d115c build: bump version to v29.1 final (fanquake) b0d88bc doc: finalise release notes for 29.1 (fanquake) 99ab2e7 ci: return to using dash in CentOS job (fanquake) 6448ebb doc: Remove wrong and redundant doxygen tag (MarcoFalke) Pull request description: Backports: * #33236 * #33261 Since `rc2`, #33212 was also backported in #33251. ACKs for top commit: glozow: ACK 084c95a willcl-ark: ACK 084c95a Tree-SHA512: 0698e5b2d12f7328bf5af8dbbd92b0049de401c0a4af27fda2209f9aab35d827c5ac65eb9268aa1fae241e3adf0d3dd89324bb288655ead8af2b5584aae1f6d2
morozow
pushed a commit
to morozow/bitcoin_rd
that referenced
this pull request
May 8, 2026
c115cf1 test: index with an unclean restart after a reorg (Martin Zumsande) 794b0d1 index: don't commit state in BaseIndex::Rewind (Martin Zumsande) Pull request description: Backports bitcoin#33212 to 29.x ACKs for top commit: achow101: ACK c115cf1 stickies-v: ACK c115cf1 mzumsande: Code Review ACK c115cf1 Tree-SHA512: eeb9213f03bbb1d48c3ccb12121a6e475f436895d314b5171007e7e4ee457c74b312fa7f0d1808d6221dc22b192700a93ea21c4e9e04689da7dde7e1f79e9569
morozow
pushed a commit
to morozow/bitcoin_rd
that referenced
this pull request
May 8, 2026
37dd344 doc: update manual pages for v29.1 (fanquake) 9d959a7 build: bump version to v29.1 final (fanquake) 373e718 doc: finalise release notes for 29.1 (fanquake) d7220cc ci: return to using dash in CentOS job (fanquake) 555a8fe doc: Remove wrong and redundant doxygen tag (MarcoFalke) Pull request description: Backports: * bitcoin#33236 * bitcoin#33261 Since `rc2`, bitcoin#33212 was also backported in bitcoin#33251. ACKs for top commit: glozow: ACK 37dd344 willcl-ark: ACK 37dd344 Tree-SHA512: 0698e5b2d12f7328bf5af8dbbd92b0049de401c0a4af27fda2209f9aab35d827c5ac65eb9268aa1fae241e3adf0d3dd89324bb288655ead8af2b5584aae1f6d2
ivanlele
added a commit
to ivanlele/elements
that referenced
this pull request
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #33212 to 29.x