[29.x] Backports#33344
Merged
Merged
Conversation
The `SHA256AutoDetect` return output is used, among other use cases, to name benchmarks. Using a comma breaks the CSV output. This change replaces the comma with a semicolon, which fixes the issue. Github-Pull: bitcoin#33340 Rebased-From: 790b440
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33344. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
Rather than trying to match the apt installed clang version, which is prone to intermittent issues. i.e bitcoin#33345. Github-Pull: bitcoin#33364 Rebased-From: b736052
1e99c7b to
eb94d29
Compare
Github-Pull: bitcoin#33310 Rebased-From: 93a29ff
eb94d29 to
3691b62
Compare
Since bitcoin#29412, we have not allowed mutated blocks to continue being processed immediately the block is received, but this is only done for the legacy BLOCK message. Extend these checks as belt-and-suspenders to not allow similar mutation strategies to affect relay by honest peers by applying the check inside PartiallyDownloadedBlock::FillBlock, immediately before returning READ_STATUS_OK. This also removes the extraneous CheckBlock call. Github-Pull: bitcoin#32646 Rebased-From: bac9ee4
Github-Pull: bitcoin#32646 Rebased-From: 28299ce
Previously in debug builds, this would cause an Assume crash if FillBlock had been called previously. This could happen when multiple blocktxn messages were received. Co-Authored-By: Greg Sanders <gsanders87@gmail.com> Github-Pull: bitcoin#33296 Rebased-From: 5e585a0
Add test_multiple_blocktxn_response that checks that the peer is disconnected. Github-Pull: bitcoin#33296 Rebased-From: 8b62647
3691b62 to
dac9608
Compare
This was referenced Sep 12, 2025
Member
Contributor
Tor inbound connections do not reveal the peer's actual network address. Therefore do not apply whitelist permissions to them. Co-authored-by: Vasil Dimov <vd@FreeBSD.org> Github-Pull: bitcoin#33395 Rebased-From: f563ce9
be76435 to
6adce94
Compare
6adce94 to
f2bd79f
Compare
darosior
approved these changes
Sep 17, 2025
morozow
pushed a commit
to morozow/bitcoin_rd
that referenced
this pull request
May 8, 2026
0a16d2c doc: update manual pages for v29.2rc1 (fanquake) 61cef88 build: bump version to v29.2rc1 (fanquake) f0fddcc doc: update release notes for 29.x (fanquake) 224d51f net: Do not apply whitelist permission to onion inbounds (Martin Zumsande) a898b24 test: send duplicate blocktxn message in p2p_compactblocks.py (Eugene Siegel) 811c49a net: check for empty header before calling FillBlock (Eugene Siegel) 549ef1c p2p: remove vestigial READ_STATUS_CHECKBLOCK_FAILED (Greg Sanders) 646d645 p2p: Add witness mutation check inside FillBlock (Greg Sanders) d5f9992 trace: Workaround GCC bug compiling with old systemtap (Luke Dashjr) e918dee ci: always use tag for LLVM checkout (fanquake) f7f635c Fix benchmark CSV output (Hennadii Stepanov) Pull request description: Backports: * bitcoin#32646 * bitcoin#33296 * bitcoin#33310 * bitcoin#33340 * bitcoin#33364 * bitcoin#33395 Plus changes for 29.2rc1. ACKs for top commit: darosior: utACK 0a16d2c mzumsande: utACK 0a16d2c Tree-SHA512: 346a92032b7a069e2941056c6273ff65e360c5834832b106350a9cd42b634518cc75b807da6e51a6292e3a33342bb7b145777d3538a2792e03c63962d747a025
ivanlele
added a commit
to ivanlele/elements
that referenced
this pull request
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports:
Plus changes for 29.2rc1.