[30.0] rc2 backports#33356
Merged
Merged
Conversation
during text selection by only setting plaintext mime data. Github-Pull: bitcoin-core/gui#886 Rebased-From: 6a371b7
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33356. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
Rather than trying to match the apt installed clang version, which is prone to intermittent issues. i.e bitcoin#33345. Github-Pull: bitcoin#33364 Rebased-From: b736052
Github-Pull: bitcoin#33310 Rebased-From: 93a29ff
If something is imported into the wallet, it can change the 'from me' status of a transaction. This status is only visible through gettransaction's "fee" field which is only shown for transactions that are 'from me'. Github-Pull: bitcoin#33268 Rebased-From: e76c2f7
Instead of checking whether the total amount of inputs known by the wallet is greater than 0, we should be checking for whether the input is known by the wallet. This enables us to determine whether a transaction spends an of output with an amount of 0, which is necessary for marking 0-value dust outputs as spent. Github-Pull: bitcoin#33268 Rebased-From: 39a7dbd
Github-Pull: bitcoin#33268 Rebased-From: c40dc82
Github-Pull: bitcoin#33268 Rebased-From: 609d265
m_cached_from_me is used to track whether a transaction is "from me", i.e. has any inputs which belong to the wallet. This is held in memory only in the same way that a transaction's balances are. Github-Pull: bitcoin#33268 Rebased-From: 113a422
The `enable_language` command must be called in file scope, not in a function call. See: https://cmake.org/cmake/help/latest/command/enable_language.html Github-Pull: bitcoin#33379 Rebased-From: 9193c3e
added 2 commits
September 15, 2025 10:23
Github-Pull: bitcoin#33243 Rebased-From: facfde2
Github-Pull: bitcoin#33243 Rebased-From: fa96a4a
mzumsande pointed out bitcoin#32345 (comment) that this test was causing a warning: Warning: Disk space for "/tmp/test_common bitcoin/node_init_tests/init_test/bf78678cb7723a3e84b5/blocks" may not accommodate the block files. Approximately 810 GB of data will be stored in this directory. Fix by setting regtest instead of mainnet network before running the test. Github-Pull: bitcoin#33391 Rebased-From: bdf01c6
Co-Authored-By: Sjors Provoost <sjors@sprovoost.nl> Github-Pull: bitcoin#33380 Rebased-From: 0a26731
Tor inbound connections do not reveal the peer's actual network address. Therefore do not apply whitelist permissions to them. Co-authored-by: Vasil Dimov <vd@FreeBSD.org> Github-Pull: bitcoin#33395 Rebased-From: f563ce9
Github-Pull: bitcoin#33407 Rebased-From: 7584a4f
darosior
approved these changes
Sep 17, 2025
morozow
pushed a commit
to morozow/bitcoin_rd
that referenced
this pull request
May 8, 2026
6b222a3 cmake: Install `bitcoin` manpage (Hennadii Stepanov) 6d44e0e net: Do not apply whitelist permission to onion inbounds (Martin Zumsande) 5357c58 test: Add submitblock test in interface_ipc (TheCharlatan) 8247fdd test: Prevent disk space warning during node_init_tests (Ryan Ofsky) 609a121 ci: Enable CI_LIMIT_STACK_SIZE=1 in i686_no_ipc task (MarcoFalke) f492aec test: Fix CLI_MAX_ARG_SIZE issues (MarcoFalke) 393b45d cmake: Fix regression in `secp256k1.cmake` (Hennadii Stepanov) a4874b8 wallet: Add m_cached_from_me to cache "from me" status (Ava Chow) c831d6a test: Add a test for anchor outputs in the wallet (Ava Chow) 0d311f7 wallet: Throw an error in sendall if the tx size cannot be calculated (Ava Chow) bd80dc7 wallet: Determine IsFromMe by checking for TXOs of inputs (Ava Chow) 19da90f test: Test wallet 'from me' status change (Ava Chow) 6b1d3da trace: Workaround GCC bug compiling with old systemtap (Luke Dashjr) b776b2e ci: always use tag for LLVM checkout (fanquake) 7c96632 gui: Avoid pathological QT text/markdown behavior... (David Gumberg) Pull request description: Backports: * bitcoin#33243 * bitcoin#33268 * bitcoin#33310 * bitcoin#33364 * bitcoin#33379 * bitcoin#33380 * bitcoin#33391 * bitcoin#33407 * bitcoin-core/gui#886 ACKs for top commit: darosior: utACK 6b222a3 hebasto: ACK 6b222a3, I applied all backports locally without conflicts and obtained a zero diff with this PR branch. Tree-SHA512: 257cc5bd0423fbf2aff62c72957faea3de8731353d809b11e18d0e5cad174c7023dca9dedd0c73e07497eb804b7c48355a055b4461db260e2f0a5712d2514ff6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports:
secp256k1.cmake#33379bitcoinmanpage #33407