[29.x] Finalise 29.2rc2#33534
Merged
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33534. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
QT translations are optional, but the script would error when 'translations_dir' falls back to its default value NULL. This PR fixes it by moving the set-up of QT translations under the check for 'translations_dir' presence. Github-Pull: bitcoin#33482 Rebased-From: 7b5261f
ca86f36 to
513cef7
Compare
Contributor
be32191 to
d82fc69
Compare
glozow
reviewed
Oct 3, 2025
Contributor
|
reACK d82fc69 |
morozow
pushed a commit
to morozow/bitcoin_rd
that referenced
this pull request
May 8, 2026
a735fe5 doc: update release notes for 29.2rc2 (fanquake) 69cd3ef doc: update manual pages for v29.2rc2 (fanquake) f7f8689 build: bump version to v29.2rc2 (fanquake) ed62c32 contrib: fix using macdploy script without translations. (amisha) Pull request description: It's been 2 weeks since rc1: https://github.com/bitcoin/bitcoin/releases/tag/v29.2rc1. We've backported more changes: * bitcoin#33403 * bitcoin#33474 * bitcoin#33482 Lets do `rc2`. ACKs for top commit: davidgumberg: reACK a735fe5 glozow: ACK a735fe5 darosior: utACK a735fe5. Changes look good to me, but i have not been through the process of regenerating the doc myself. Tree-SHA512: c829efe89f86c9c76767ffe60a3779ece902ee9e3c8f6b4203562aaf257019484bfa49916ddfabdcabbd1478368d9b80a3f0a15057778aa1984852ea245283a6
ivanlele
added a commit
to ivanlele/elements
that referenced
this pull request
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's been 2 weeks since rc1: https://github.com/bitcoin/bitcoin/releases/tag/v29.2rc1.
We've backported more changes:
Lets do
rc2.