DRAFT: add a freebsd job using systemlibs by willcl-ark · Pull Request #33562 · bitcoin/bitcoin

willcl-ark · 2025-10-07T11:35:43Z

Test a basic freebsd job in this repo using cirrus runners to get some info on how long a run will take on Cirrus Runners.

A run on GHA (free) runners is clocking in at around 50 - 60 minutes: https://github.com/willcl-ark/bitcoin/actions/runs/18309856374/job/52135663056

This will need permitting of the vmactions/freebsd-vm@v1 action in this repo. This action seems well-maintained/used, including by rustup, python psutil and a few other notable repos.

This job could alternatively be run as a nightly job (but in this repo, rather than elsewhere), but that does not seem to address:

BSDs are being tested in nightly repos, but merging code here, just to have it reported as broken after the fact, which then requires more changes to fix, isn't ideal. Issues should be caught in this repo, before merging.

Inspiration taken from https://github.com/hebasto/bitcoin-core-nightly/blob/main/.github/workflows/freebsd.yml

DrahtBot · 2025-10-07T11:35:48Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33562.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#bitcoin-core/gui/896 (rpcconsole: display signet challenge by RandyMcMillan)
#33620 (ci: Build ci_native_base image layer by maflcko)
#33549 (ci: Add macOS cross task for arm64-apple-darwin by maflcko)
#33514 (Clear out space on GHA jobs by willcl-ark)
#33480 (ci: Turn CentOS config into Alpine musl config by maflcko)
#33461 (ci: add Valgrind fuzz by fanquake)
#33411 (ci: re-add Valgrind job to the CI by fanquake)
#33142 (test: Run bench sanity checks in parallel with functional tests by maflcko)
#31507 (build: Use clang-cl to build on Windows natively by hebasto)
#31425 (RFC: Riscv bare metal CI job by TheCharlatan)
#31410 (qa: Fix wallet_multiwallet.py by hebasto)
#30595 (kernel: Introduce C header API by TheCharlatan)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

maflcko · 2025-10-08T09:10:17Z

+          CMAKE_GENERATOR: 'Ninja'
+        run: |
+          cd ${{ github.workspace }}
+          cmake -B build -DWITH_ZMQ=ON -DBUILD_BENCH=ON -DWERROR=ON -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache


no strong opinion, but is there a rationale about the scope here? why disable the fuzz binary?

No opinion from me either, this is just a tranlation mistake from https://github.com/hebasto/bitcoin-core-nightly/blob/36cc3ef2703d6f662e9a96c21db5d83d80e7efb9/.github/workflows/freebsd.yml#L58 where it is indeed enabled.

I will re-enable it in next push.

hebasto · 2025-10-10T12:46:47Z

This will need permitting of the vmactions/freebsd-vm@v1 action in this repo.

A few comments for historical context:

ci: Add FreeBSD GitHub Actions job #30164 (comment):

Not sure. What was the conclusion when GHA was added to the repo about enabling third party actions? IIRC it was unclear whether malicious or backdoored actions could compromise the repo, so the conclusion was to refrain from enabling them?

No objection to merging this, but I'd say unless it is clear that the repo can not be compromised, the action should not be enabled in this repo.

ci: Add FreeBSD GitHub Actions job #30164 (comment):

Albeit this seems fine (ci: Add FreeBSD GitHub Actions job #30164 (comment)), I think adding third-party actions should be limited as well.

The third-party action has limited usage and exposure, so it may break from down under us, marking all CI runs red.

And just recently, #32513 has resolved #32508.

maflcko · 2025-10-10T13:57:07Z

Yeah, this would be adding FreeBSD to add coverage for a single short-term compile time issue encountered there. Though, we'd still be missing OpenBSD/NetBSD coverage for stuff that is different on those platforms: #33128 (which seems like a long-standing issue that has existed since ever and no one bothered to report?)

DrahtBot · 2025-10-15T11:53:50Z

🐙 This pull request conflicts with the target branch and needs rebase.

hebasto · 2025-12-30T14:21:20Z

All vmactions/*-vm actions are now unconditionally cached using the repository's GHA quota.

maflcko · 2025-12-30T14:51:20Z

Are you still working on this? If not, it can probably be closed

willcl-ark · 2025-12-31T11:28:46Z

Yeah, from the above it seems like we are happy to just continue running the various *BSDs on nightly jobs. Will close for now.

hebasto · 2026-01-28T08:31:34Z

All vmactions/*-vm actions are now unconditionally cached using the repository's GHA quota.

This is now configurable as of v1.3.8: https://github.com/vmactions/freebsd-vm/releases/tag/v1.3.8.

fanquake · 2026-01-29T14:01:06Z

Does that mean this job is more viable to add now?

maflcko · 2026-01-29T17:12:39Z

I'd say the opposite: I think we've learned that upstream can control at their will whether to cache something or not. I don't really understand the GHA ecosystem and I think it is horrible (#33562 (comment)), but I guess this is just me and maybe this is fine and we can enable this third-party single-person-maintainer action here?

65379bb ci: add FreeBSD cross CI job (fanquake) f44191f depends: build qrencode for Freebsd (fanquake) 7f70187 depends: FreeBSD cross with Clang (fanquake) 6464f14 depends: disable inotify in Freebsd Qt build (fanquake) Pull request description: Alternative to #33562, which was adding a native FreeBSD job; however that had issues with permissions/caching, as well as potential determinism issues. This adds a FreeBSD cross job using Linux and Clang. Would close #33438. The same changes here could also be used to produce FreeBSD binaries out of Guix. ACKs for top commit: hebasto: ACK 65379bb. I've cross-compiled on Ubuntu 25.10 for FreeBSD 14.4 and 15.0. The former binaries (`bitcoind`, `test_bitcoin` and `bitcoin-qt`) were tested on FreeBSD 14.4 locally. Tree-SHA512: 52a3edaa56fe40ca901416cb9e1af04a84505526edfa7309bfa40024baa7d3b1a05303659553d9fbcf1f49d4e3d42b415a1e2523d448b22724d1415a49331259

DrahtBot added the Needs rebase label Oct 8, 2025

willcl-ark force-pushed the freebsd-job branch from e0c6325 to 8f6d0cc Compare October 8, 2025 09:00

maflcko reviewed Oct 8, 2025

View reviewed changes

DrahtBot added Needs rebase and removed Needs rebase labels Oct 8, 2025

willcl-ark added 3 commits October 10, 2025 10:03

ci: add freebsd systemlibs job

6366875

NOMERGE: disable a few tests

b749876

NOMERGE: freebsd, save a cache

dadceeb

willcl-ark force-pushed the freebsd-job branch from 8f6d0cc to dadceeb Compare October 10, 2025 09:03

DrahtBot removed the Needs rebase label Oct 10, 2025

DrahtBot mentioned this pull request Oct 14, 2025

ci: Build ci_native_base image layer #33620

Closed

DrahtBot added the Needs rebase label Oct 15, 2025

willcl-ark closed this Dec 31, 2025

fanquake mentioned this pull request Feb 3, 2026

ci: add FreeBSD Clang cross job #34491

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

DRAFT: add a freebsd job using systemlibs#33562

DRAFT: add a freebsd job using systemlibs#33562
willcl-ark wants to merge 3 commits into
bitcoin:masterfrom
willcl-ark:freebsd-job

willcl-ark commented Oct 7, 2025

Uh oh!

DrahtBot commented Oct 7, 2025 •

edited

Loading

Uh oh!

maflcko Oct 8, 2025

Uh oh!

willcl-ark Oct 8, 2025

Uh oh!

hebasto commented Oct 10, 2025

Uh oh!

maflcko commented Oct 10, 2025

Uh oh!

DrahtBot commented Oct 15, 2025

Uh oh!

hebasto commented Dec 30, 2025

Uh oh!

maflcko commented Dec 30, 2025

Uh oh!

willcl-ark commented Dec 31, 2025

Uh oh!

hebasto commented Jan 28, 2026

Uh oh!

fanquake commented Jan 29, 2026

Uh oh!

maflcko commented Jan 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

willcl-ark commented Oct 7, 2025

Uh oh!

DrahtBot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage & Benchmarks

Reviews

Conflicts

Uh oh!

maflcko Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

willcl-ark Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

hebasto commented Oct 10, 2025

Uh oh!

maflcko commented Oct 10, 2025

Uh oh!

DrahtBot commented Oct 15, 2025

Uh oh!

hebasto commented Dec 30, 2025

Uh oh!

maflcko commented Dec 30, 2025

Uh oh!

willcl-ark commented Dec 31, 2025

Uh oh!

hebasto commented Jan 28, 2026

Uh oh!

fanquake commented Jan 29, 2026

Uh oh!

maflcko commented Jan 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

DrahtBot commented Oct 7, 2025 •

edited

Loading