Skip to content

test: Detect truncated download in get_previous_releases.py #34040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fanquake merged 1 commit into from
Dec 10, 2025
Merged

test: Detect truncated download in get_previous_releases.py #34040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion test/get_previous_releases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def progress_hook(progress_bytes, total_size):
if response.status != 200:
raise RuntimeError(f"HTTP request failed with status code: {response.status}")

total_size = int(response.getheader('Content-Length', 0))
total_size = int(response.getheader("Content-Length"))

@l0rinc l0rinc Dec 10, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If missing, this would fail with TypeError, right?

nit to minimize diff:

Suggested change
total_size = int(response.getheader("Content-Length"))
total_size = int(response.getheader('Content-Length'))

@maflcko maflcko Dec 10, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

black prefers this, so I'll leave this as-is for now

progress_bytes = 0

with open(archive, 'wb') as file:
Expand All @@ -134,6 +134,9 @@ def progress_hook(progress_bytes, total_size):
progress_bytes += len(chunk)
progress_hook(progress_bytes, total_size)

if progress_bytes < total_size:

@l0rinc l0rinc Dec 10, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could be stricter and make it !=

@maflcko maflcko Dec 10, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will leave as-is for now

@maflcko maflcko Dec 11, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, progress_bytes < total_size: could be considered stricter, because if the server starts replying with the wrong payload size, or appends data, it seems like this could be useful to know via a checksum error.

raise RuntimeError(f"Download incomplete: expected {total_size} bytes, got {progress_bytes} bytes")

print('\n', flush=True, end="") # Flush to avoid error output on the same line.


Expand Down
Loading