[30.2] Backports & Final#34229
Merged
Merged
Conversation
The test calls migrate_and_get_rpc(), which sets mock time internally. The caller caches a mock time value and later relies on it to predict the backup filename, so setting the mock time again could cause a naming mismatch. Fix this by calling the migration RPC directly. Since the test expects the migration to fail, migrate_and_get_rpc() is unnecessary here. Github-Pull: bitcoin#34221 Rebased-From: cbf0bd3
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34229. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste LLM Linter (✨ experimental)Possible typos and grammar issues:
2026-01-09 |
furszy
reviewed
Jan 8, 2026
Contributor
Refactor a common way to perform the failed migration test that exists for default wallets, and add relative-path wallets and absolute-path wallets. Github-Pull: bitcoin#34226 Rebased-From: eeaf28d
Github-Pull: bitcoin#34227 Rebased-From: 194114d
willcl-ark
approved these changes
Jan 9, 2026
willcl-ark
left a comment
Member
There was a problem hiding this comment.
ACK 04a996b
Backports are clean and in release notes.
pinheadmz
added a commit
to pinheadmz/quorumeum
that referenced
this pull request
Feb 13, 2026
bitcoin/bitcoin at 4d7d5f6
morozow
pushed a commit
to morozow/bitcoin_rd
that referenced
this pull request
May 8, 2026
2f62457 doc: update manual pages for v30.2 (fanquake) bc5cd8e build: bump version to v30.2 (fanquake) 43bab7f doc: update release notes for v30.2 (fanquake) 9fa5f11 guix: Fix `osslsigncode` tests (Hennadii Stepanov) b74ecd4 wallet: test: Failed migration cleanup (David Gumberg) 3024f52 test: migration, avoid backup name mismatch in default_wallet_failure (furszy) Pull request description: Backports: * bitcoin#34221 * bitcoin#34226 * bitcoin#34227 ACKs for top commit: hebasto: ACK 2f62457, I have reviewed the code and it looks OK. willcl-ark: ACK 2f62457 marcofleon: ACK 2f62457 Tree-SHA512: 3389b9b629dcb920186b383353fd386bb757967d224e0267501b5e2083dc1e6cba051df6ef646de05c0e58fd43c9f549b9175eefb77fed1fe9ab7d1648b2d9e7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports:
osslsigncodetests #34227