Skip to content

test: Fix intermittent failure in feature_assumevalid.py by ensuring invalid block was processed before checking debug.log #34528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sedited merged 1 commit into from
Feb 7, 2026
Merged

test: Fix intermittent failure in feature_assumevalid.py by ensuring invalid block was processed before checking debug.log #34528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/functional/feature_assumevalid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ def run_test(self):
self.send_blocks_until_disconnected(p2p0)
self.wait_until(lambda: self.nodes[0].getblockcount() >= COINBASE_MATURITY + 1)
assert_equal(self.nodes[0].getblockcount(), COINBASE_MATURITY + 1)
self.wait_until(lambda: next(filter(lambda x: x["hash"] == self.blocks[-1].hash_hex, self.nodes[0].getchaintips()))["status"] == "invalid")

@maflcko maflcko Feb 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the wrong fix, and it is also incomplete:

  • It is wrong, because send_blocks_until_disconnected should wait until the disconnect (it does not), so the real bug is in send_blocks_until_disconnected.
  • The same fix is needed for nodes[2] below

Fixed both issues in #34571



# nodes[1]
Expand Down
Loading