[30.x] Partial backport #34650#34754
Merged
Merged
Conversation
The `find_package(Qt .. MODULE REQUIRED COMPONENTS ...)` call must treat any missing component as a fatal error. Github-Pull: bitcoin#34650 Rebased-From: c555845
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste |
Member
Author
|
Looking into an error when cross-compiling for ARM32... |
Backported from: qt/qtbase@7fccc79 Github-Pull: bitcoin#34650 Rebased-From: d7e972a
Meta-Issue: https://qt-project.atlassian.net/browse/QTBUG-143470 Backports: qt/qtbase@679e8bd qt/qtbase@3312e89 qt/qtbase@05f201a An additional includes fix is needed after the others: qt/qtbase@d68fc6e Github-Pull: bitcoin#34650 Rebased-From: 3cb4d60
Github-Pull: bitcoin#34650 Rebased-From: 473e5f8
ef15c61 to
fbfc778
Compare
Member
Author
|
Undrafted. |
Member
|
ACK fbfc778 |
Member
|
utACK fbfc778
Makes sense to drop this QT bump but take the fixes on a stable branch. Rest of the backports look correct, mainly differing on patch metadata. It is missing a release note, is that intentional as it's "partial"? |
Member
I think we can add a partial release note in #34689. |
morozow
pushed a commit
to morozow/bitcoin_rd
that referenced
this pull request
May 8, 2026
25dc6d0 qt: Add patch to fix SFINAE warnings in QAnyStringView with gcc16 (Hennadii Stepanov) db5fdc1 qt: add patches to fix SFINAE errors/warnings with gcc16 (Cory Fields) 63820a4 qt: add patch to fix build with gcc16 (Cory Fields) 8048c70 cmake: Fix `FindQt` module (Hennadii Stepanov) Pull request description: This PR backports commits from bitcoin#34650 not related to Qt update. They fix issues when building with GCC 16 and improves Qt detecting. ACKs for top commit: fanquake: ACK 25dc6d0 willcl-ark: utACK 25dc6d0 Tree-SHA512: dd2d1b23aaad64a8eb6a279dbb7def1b29149cfdebd88e0667ebbccfd30ad9762f90dbbc6968eae148e724f0257646939360765c2fae1b5d513a11cf0c2902d8
Merged
sedited
added a commit
that referenced
this pull request
Jun 23, 2026
d52747d doc: update manual pages for v30.3rc1 (fanquake) a1406d6 build: bump version to v30.3rc1 (fanquake) 1bdd2b1 doc: update release notes for v30.3rc1 (fanquake) e7c6d39 fuzz: Remove unused g_setup pointers (MarcoFalke) b7c7d1e coins: compact chainstate in background (Lőrinc) 992b1dd validation: randomly compact chainstate (Lőrinc) 55ead70 coins: test chainstate flush baseline (Lőrinc) d09bd0f lint: disable leveldb subtree check (fanquake) Pull request description: Backports: * #34918 * #35465 Final changes for v`30.3rc1`. Backports since `30.2`: * #34283 * #34459 * #34689 * #34754 * #34805 * #34856 * #35211 * #35232 ACKs for top commit: sedited: ACK d52747d marcofleon: ACK d52747d Tree-SHA512: 75fb64f744a0689a9bc4f5a25128bf2aaad7459d7a430f552200b995498428d89de28820f477780f95e7e8485eea9f657ad5fdeae253940df4f29bf51346b4ff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports commits from #34650 not related to Qt update. They fix issues when building with GCC 16 and improves Qt detecting.