The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35140.

Reviews

See the guideline for information on the review process.

If your review is incorrectly listed, please copy-paste <!--meta-tag:bot-skip--> into the comment that the bot should ignore.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #35397 (ci: add OpenBSD Clang cross job by fanquake)
• #35378 (ci: switch to warp runners by willcl-ark)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

LLM disclaimer: This diff was written by OpenAI Codex

I thought they were supposed to keep going until June 1, but it looks like the runners are gone... All current CI tasks that used their runners are stuck on "waiting for a runner".

ACK fa43cfd

Yeah, idk either. I can also only see that it is down, but we'll have to do the switch anyway, and this is just a temporary workaround.

If the CI passes here, but not otherwise, it seems fine to merge, but should also be fine to wait longer.

timed out ...

timed out ...

Interesting as it has been working on forks. I wonder if a primed cache would have helped. I see you have updated the timeouts now which seems reasonable.

Concept ACK, even if this only a very temporary solution. Things will back up and be very slow but some runs is better than no runs.

ACK fae494a - With the understanding that Cirrus Runners are unavailable

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

rebased for gha cache, which should be picked up here

Looks like the cache is working again. https://github.com/bitcoin/bitcoin/actions/runs/26287233799/job/77380011110?pr=35140#step:10:185:

+ docker buildx build --file=/home/runner/work/bitcoin/bitcoin/ci/test_imagefile --build-arg=CI_IMAGE_NAME_TAG=mirror.gcr.io/debian:trixie --build-arg=FILE_ENV=./ci/test/00_setup_env_arm.sh --build-arg=BASE_ROOT_DIR=/home/runner/work/_temp --platform=linux/arm64 --label=bitcoin-ci-test --tag=ci_arm_linux --cache-from type=gha,scope=ci_arm_linux --load /home/runner/work/bitcoin/bitcoin
#0 building with "builder-a629b1c4-df8d-4392-be07-d44f07b76ca1" instance using docker-container driver

#1 [internal] load build definition from test_imagefile
#1 transferring dockerfile:
#1 transferring dockerfile: 946B 0.0s done
#1 DONE 0.1s

#2 [internal] load metadata for mirror.gcr.io/debian:trixie
#2 DONE 1.8s

#3 [internal] load .dockerignore
#3 transferring context: 2B done
#3 DONE 0.1s

#4 [internal] load build context
#4 DONE 0.0s

#5 [1/5] FROM mirror.gcr.io/debian:trixie@sha256:4ae67669760b807c19f23902a3fd7c121a6a70cf2ae709035674b23e712e4d62
#5 resolve mirror.gcr.io/debian:trixie@sha256:4ae67669760b807c19f23902a3fd7c121a6a70cf2ae709035674b23e712e4d62 0.0s done
#5 DONE 0.1s

#6 importing cache manifest from gha:11209079260555040155
#6 DONE 0.2s

#4 [internal] load build context
#4 transferring context: 47.02kB done
#4 DONE 0.1s

#7 [3/5] COPY ./ci/test/00_setup_env.sh ././ci/test/00_setup_env_arm.sh ./ci/test/01_base_install.sh ./ci/test/01_iwyu.patch /ci_container_base/ci/test/
#7 CACHED

#8 [4/5] RUN sh -c "bash -c 'true' || ( apk update && apk add --no-cache bash )"
#8 CACHED

#9 [2/5] COPY ./ci/retry/retry /usr/bin/retry
#9 CACHED

#10 [5/5] RUN ["bash", "-c", "cd /ci_container_base/ && set -o errexit && source ./ci/test/00_setup_env.sh && DANGER_RUN_CI_ON_HOST=1 ./ci/test/01_base_install.sh"]
#10 CACHED

and further below:

Cacheable calls:     872 / 872 (100.0%)
  Hits:              871 / 872 (99.89%)

Hmm, actually the other caches are not working for some reason. https://github.com/bitcoin/bitcoin/actions/runs/26287233799/job/77380011168?pr=35140#step:5:46:

Prepare all required actions
Getting action download info
Download action repository 'actions/cache@v5' (SHA:27d5ce7f107fe9357f9df03efb73ab90386fccae)
Run ./.github/actions/restore-caches
Run actions/cache/restore@v5
Cache not found for input keys: ccache-ci_macos_cross-26287233799, ccache-ci_macos_cross-
Run actions/cache/restore@v5
Cache not found for input keys: depends-sources-ci_macos_cross-6af50d1e88ded1eb8c28fd886f8a6fd44c5851c793a63de32d3dabb5e561356a, depends-sources-ci_macos_cross-
Run actions/cache/restore@v5
Cache not found for input keys: depends-built-ci_macos_cross-6af50d1e88ded1eb8c28fd886f8a6fd44c5851c793a63de32d3dabb5e561356a, depends-built-ci_macos_cross-
Run actions/cache/restore@v5
Cache not found for input keys: previous-releases-ci_macos_cross-4036882c078a4ebb9f71a708667a51a3073a8316d45d1e1dd410a990e78660d7, previous-releases-ci_macos_cross-
Run echo "depends-sources-cache-hit=" >> $GITHUB_ENV

Maybe close for now, and we revisit if #35378 doesn't land?

Yeah, seems fine to close if that is merged.

Though, out of curiosity, I wonder why the caches are missed here (#35140 (comment)), considering that they were moved to GHA in #35348, and considering that this pull does not change anything about the caching.

Hmm, actually the other caches are not working for some reason. https://github.com/bitcoin/bitcoin/actions/runs/26287233799/job/77380011168?pr=35140#step:5:46:

Prepare all required actions
Getting action download info
Download action repository 'actions/cache@v5' (SHA:27d5ce7f107fe9357f9df03efb73ab90386fccae)
Run ./.github/actions/restore-caches
Run actions/cache/restore@v5
Cache not found for input keys: ccache-ci_macos_cross-26287233799, ccache-ci_macos_cross-
Run actions/cache/restore@v5
Cache not found for input keys: depends-sources-ci_macos_cross-6af50d1e88ded1eb8c28fd886f8a6fd44c5851c793a63de32d3dabb5e561356a, depends-sources-ci_macos_cross-
Run actions/cache/restore@v5
Cache not found for input keys: depends-built-ci_macos_cross-6af50d1e88ded1eb8c28fd886f8a6fd44c5851c793a63de32d3dabb5e561356a, depends-built-ci_macos_cross-
Run actions/cache/restore@v5
Cache not found for input keys: previous-releases-ci_macos_cross-4036882c078a4ebb9f71a708667a51a3073a8316d45d1e1dd410a990e78660d7, previous-releases-ci_macos_cross-
Run echo "depends-sources-cache-hit=" >> $GITHUB_ENV

I don't know why this didn't hit but I can see some later jobs hitting this cache and building quickly: https://github.com/bitcoin/bitcoin/actions/runs/26527924738/job/78136523172

🐙 This pull request conflicts with the target branch and needs rebase.

Closing for now, given warp has been merged.