Skip to content

lint: remove redundant test suite uniqueness check #35520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sedited merged 1 commit into from
Jun 16, 2026
Merged

lint: remove redundant test suite uniqueness check #35520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 3 additions & 41 deletions test/lint/lint-tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ def grep_boost_test_suites():
return subprocess.check_output(command, text=True)


def check_matching_test_names(test_suite_list):
def main():
test_suite_list = grep_boost_test_suites().splitlines()
not_matching = [
x
for x in test_suite_list
Expand All @@ -42,46 +43,7 @@ def check_matching_test_names(test_suite_list):
f"{not_matching}\n"
)
print(error_msg)
return 1
return 0


def get_duplicates(input_list):
"""
From https://stackoverflow.com/a/9835819
"""
seen = set()
dupes = set()
for x in input_list:
if x in seen:
dupes.add(x)
else:
seen.add(x)
return dupes


def check_unique_test_names(test_suite_list):
output = [re.search(r"\((.*?)[,)]", x) for x in test_suite_list]
output = [x.group(1) for x in output if x is not None]
output = get_duplicates(output)
output = sorted(list(output))

if len(output) > 0:
output = "\n".join(output)
error_msg = (
"Test suite names must be unique. The following test suite names\n"
f"appear to be used more than once:\n\n{output}"
)
print(error_msg)
return 1
return 0


def main():
test_suite_list = grep_boost_test_suites().splitlines()
exit_code = check_matching_test_names(test_suite_list)
exit_code |= check_unique_test_names(test_suite_list)
sys.exit(exit_code)
sys.exit(1)


if __name__ == "__main__":
Expand Down
Loading