build: QRencode cleanups#35603
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35603. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste |
|
@purpleKarrot also suggested:
I'm not sure about that, as currently However, I'm still open for further discussion. |
|
|
Co-authored-by: Daniel Pfeifer <daniel@pfeifer-mail.de>
Thanks! Taken. |
|
ACK 829255c |
|
My Guix build: |
|
I've got this Guix build for 39ed6fa2d8b901b7cca10eb297f422c0d9697191188e6ba97b8201c816d53798 guix-build-829255c8bedc/output/aarch64-linux-gnu/SHA256SUMS.part
61b9fdcce254bfd9f53b914ab525ba5309ec04344ed8c4546270f643c7fcd94e guix-build-829255c8bedc/output/aarch64-linux-gnu/bitcoin-829255c8bedc-aarch64-linux-gnu-debug.tar.gz
f41b4ca07cfb18130c407d3bfc616f1229a16e74adb53f1db133907b5fda967c guix-build-829255c8bedc/output/aarch64-linux-gnu/bitcoin-829255c8bedc-aarch64-linux-gnu.tar.gz
6f9d026d341471e0454d8289830b00515a07b4a723252707c270063d3ff34423 guix-build-829255c8bedc/output/arm-linux-gnueabihf/SHA256SUMS.part
ee2755a24a507534e965d1042ff4757dead76eac22bfe0755f611f357ad318af guix-build-829255c8bedc/output/arm-linux-gnueabihf/bitcoin-829255c8bedc-arm-linux-gnueabihf-debug.tar.gz
e17db3f0e30aa4384f2399310637095b01c44db03a112bce1b873e8d0718457b guix-build-829255c8bedc/output/arm-linux-gnueabihf/bitcoin-829255c8bedc-arm-linux-gnueabihf.tar.gz
ecb89ab07b51af033df4576d7a6030e139843673192f62cb464c9f633f699cfc guix-build-829255c8bedc/output/arm64-apple-darwin/SHA256SUMS.part
8f63120989e6495c04f632e5b8173f5301fe5f30dac63c7dde1cc1cf5f40beb0 guix-build-829255c8bedc/output/arm64-apple-darwin/bitcoin-829255c8bedc-arm64-apple-darwin-codesigning.tar.gz
8a4edfef0052142acea349f487863e25688be65b52fb03488b4b835a7dcfba30 guix-build-829255c8bedc/output/arm64-apple-darwin/bitcoin-829255c8bedc-arm64-apple-darwin-unsigned.tar.gz
162451cd3a8875e37d9cbc0933271b77f61da28712d365c4568183fe6c4a4b99 guix-build-829255c8bedc/output/arm64-apple-darwin/bitcoin-829255c8bedc-arm64-apple-darwin-unsigned.zip
6ead25df09b663bd8211054b33d300485a1ae9742564ff261ff30d1099403942 guix-build-829255c8bedc/output/dist-archive/bitcoin-829255c8bedc.tar.gz
13d2c82ea40abebe5487f576eaaa5570bf547fa5881eb0848208e8e118587818 guix-build-829255c8bedc/output/powerpc64-linux-gnu/SHA256SUMS.part
36ec0bb067672eec90c48a76925fc7ae2aa961f76a0be2001899ddfb0ddec6e1 guix-build-829255c8bedc/output/powerpc64-linux-gnu/bitcoin-829255c8bedc-powerpc64-linux-gnu-debug.tar.gz
34004370719f4a9917ab0806fd6bfdc9b75ba0361d98ac49e41ecdc418715292 guix-build-829255c8bedc/output/powerpc64-linux-gnu/bitcoin-829255c8bedc-powerpc64-linux-gnu.tar.gz
5e8c722ff3c9b74aaf4f68fbf6a80cbc5dd3f3e088e94b78b4326d2928d40dfd guix-build-829255c8bedc/output/riscv64-linux-gnu/SHA256SUMS.part
3b9b57a931fa7c0a09420ef1c4d14518ee96529d80395f8772979dba139069b4 guix-build-829255c8bedc/output/riscv64-linux-gnu/bitcoin-829255c8bedc-riscv64-linux-gnu-debug.tar.gz
da0ed79e7d9554531c98920013ab74b6df06b92a8084a09ed011ade395529eae guix-build-829255c8bedc/output/riscv64-linux-gnu/bitcoin-829255c8bedc-riscv64-linux-gnu.tar.gz
696325fad13780bf1cc869c00f4eec1fc2a24674d81216c1ef27b18c599368f8 guix-build-829255c8bedc/output/x86_64-apple-darwin/SHA256SUMS.part
28df4d242ecdcb68740deb874f0c2da1412f13911d963734d67e15d0e2128375 guix-build-829255c8bedc/output/x86_64-apple-darwin/bitcoin-829255c8bedc-x86_64-apple-darwin-codesigning.tar.gz
d7ab6604a954a5e99c1dad3d0ee4778eca3309a7e1fa3488526910fe09660483 guix-build-829255c8bedc/output/x86_64-apple-darwin/bitcoin-829255c8bedc-x86_64-apple-darwin-unsigned.tar.gz
752b36f03ea4ce90ee63d55bfc2b5758f3d6068a3623ac05ec43d7094fe03bc0 guix-build-829255c8bedc/output/x86_64-apple-darwin/bitcoin-829255c8bedc-x86_64-apple-darwin-unsigned.zip
4e60cebd907974b9f292b23855e739bcf5490908ab3da045e2d88958df2b9aec guix-build-829255c8bedc/output/x86_64-linux-gnu/SHA256SUMS.part
3272c7736a9300f65900d1c2f372e6e62c3bfab3a243732d11d66ef00de35696 guix-build-829255c8bedc/output/x86_64-linux-gnu/bitcoin-829255c8bedc-x86_64-linux-gnu-debug.tar.gz
6013d536d27db00c2209247024640e9ddc1ed84f607b55658496c5bc3cb75e6f guix-build-829255c8bedc/output/x86_64-linux-gnu/bitcoin-829255c8bedc-x86_64-linux-gnu.tar.gz
cbb875c7cf6cd77d3a72817006db2fffd04234608598a22ef49ddb67fd086700 guix-build-829255c8bedc/output/x86_64-w64-mingw32/SHA256SUMS.part
d0731990e6df986dd761c7481e48adc51d219a2d58c264f7889ec814ca58bc61 guix-build-829255c8bedc/output/x86_64-w64-mingw32/bitcoin-829255c8bedc-win64-codesigning.tar.gz
76d6e71266c9baab1f177e28492e82f7c461156d11c20598265a716bb9d8cf59 guix-build-829255c8bedc/output/x86_64-w64-mingw32/bitcoin-829255c8bedc-win64-debug.zip
7b41d6c37f34315eabee59cc6987f9811da2a8f0e51a9a56e93ad552d308848e guix-build-829255c8bedc/output/x86_64-w64-mingw32/bitcoin-829255c8bedc-win64-setup-unsigned.exe
014b91d7d11bc46ef838d1c89a6baf65bdbbefcc03affcc38a038913040e5870 guix-build-829255c8bedc/output/x86_64-w64-mingw32/bitcoin-829255c8bedc-win64-unsigned.zip |
I think this was a local caching issue. Rebuilt on x86_64, and it matched. |
|
post merge guix build hashes: |
…f591d0b84 2df591d0b84 kernel: Add script tracer f26c15bdd28 Merge bitcoin/bitcoin#35397: ci: add OpenBSD Clang cross job dc282ff31d1 Merge bitcoin/bitcoin#35597: logging: More fully remove libevent log category ec98037f7ae Merge bitcoin/bitcoin#35615: fuzz: restore CreateSock in PCP targets 43d89bb6e10 Merge bitcoin/bitcoin#35610: bitcoin-util: Add netmagic command e35c8054894 Merge bitcoin/bitcoin#35129: test: add fuzz test for private broadcast a318f43254c bitcoin-util: Add netmagic command 3c76bd43568 Merge bitcoin/bitcoin#35603: build: QRencode cleanups 57b3bf84960 Merge bitcoin/bitcoin#35609: ci: Bump tsan config to ubuntu:26.04 with -U_FORTIFY_SOURCE d64ea158240 ci: add openBSD cross CI job 5404b620742 depends: add openbsd_LDFLAGS 2a9e35d293b Merge bitcoin/bitcoin#35588: scripted-diff: Rename `Sock::{RECV,SEND,ERR}` a0e5e30010a fuzz: restore CreateSock in PCP targets 41ceea400e8 scripted-diff: Rename `StatusLevel::{INFO,WARN,ERR}` f395acdeeea scripted-diff: Rename `Sock::{RECV,SEND,ERR}` 7a74f652935 Merge bitcoin/bitcoin#35536: fuzz: share a single mocked steady clock across FuzzedSock instances e1290ce7f74 Merge bitcoin/bitcoin#35543: test: introduce ExtendedPrivateKey and ExtendedPublicKey classes 7ac25c91771 util, refactor: Rename local `ERR` in `Sock::Accept` bbbbab86a81 ci: Bump tsan config to ubuntu:26.04 with -U_FORTIFY_SOURCE ea9afb61a1c Merge bitcoin/bitcoin#35602: doc: Clarify build docs about `pkgconf` / `pkg-config` requirements 672eedc46b0 Merge bitcoin/bitcoin#35220: fuzz: connman: strengthen assertions and extend coverage 0e5c718d8af Merge bitcoin/bitcoin#35506: test: ensure group data cluster pointers are live 93012d7ff91 Merge bitcoin/bitcoin#35601: wallet: remove experimental warning from send and sendall 829255c8bed cmake: Remove `SelectLibraryConfigurations` from `FindQRencode` module 5c55606da9b depends: Remove unused `lib/pkgconfig` in `qrencode` package 402ba10b20b cmake: Drop optional `PkgConfig` use in `FindQRencode` module 8ebfff0f88b doc: add send RPC release note fb8a1038867 doc: Clarify build docs about `pkgconf` / `pkg-config` requirements 5884f5a4fa9 wallet: remove experimental warning from send RPCs 7b84e5106c3 Merge bitcoin/bitcoin#35595: ci: remove some packages from Chimera job 58560c281d0 ci: remove some packages from Chimera job 295ce6f45c8 Merge bitcoin/bitcoin#35576: test: raise `feature_reindex` RPC timeout 633044f1436 Merge bitcoin/bitcoin#35266: rpc, wallet: add an option to not load the wallet after migrating d6269e2a903 Merge bitcoin/bitcoin#35594: fuzz: cover async chainstate compaction 3765b428d19 logging: More fully remove libevent log category 703a671fbc2 fuzz: compact coins view db during fuzzing 0868c85fd57 refactor: rename async coin compaction 6fa4132298a fuzz: share a single mocked steady clock across FuzzedSock instances 8791c4764ca test: use ExtendedPrivateKey in wallet_taproot.py 89ceafafb9f test: use ExtendedPrivateKey in wallet_listdescriptors.py bbfffcab588 test: use ExtendedPrivateKey in wallet_send.py 2ab6e590f73 test: use ExtendedPrivateKey in wallet_keypool.py 9e20118720d test: use ExtendedPrivateKey in wallet_fundrawtransaction.py 06af0cddbb9 test: use ExtendedPrivateKey in wallet_descriptor.py 4100fac20e8 test: use ExtendedPrivateKey in wallet_createwallet.py ff3f6def9a5 test: use ExtendedPrivateKey in wallet_bumpfee.py 003f2a01f63 test: use ExtendedPrivateKey in feature_notifications.py f988e6d6e64 test: use ExtendedPrivateKey in wallet_importdescriptors.py 0cdd817a82a add release note 517d37ce3eb test: tests wallet migration with load_wallet disabled b98dd63da7b rpc: Add load_wallet argument to migratewallet RPC 4acd063ba6f wallet: make loading the wallet after migrating optional 1a3cfdf1b7a fuzz: connman: cover AddLocalServices/RemoveLocalServices c507fb30634 fuzz: connman: add outbound-bytes invariants 4a6fce43ead fuzz: connman: add AddNode/RemoveAddedNode invariants 9e6546c517c test: raise reindex mining RPC timeout d2a03d50acb test: add extendedkey.py unit tests by using BIP32 test vectors afdb3780821 test: introduce ExtendedPrivateKey and ExtendedPublicKey classes 2ee4fafa3f4 test: add fuzz test for private broadcast 08b7c61fc70 private broadcast: enforce sending to unique node ids 4dbaa7cc65b test: generalise byte_to_base58 utility function to allow more version types df9eb72b129 test: ensure group data cluster pointers are live a5859edef45 fuzz: connman: set m_local_services/m_use_addrman_outgoing/m_max_automatic_connections 4b84c9125ad fuzz: connman: add network activity invariants 97d08d62baf refactor: store wallet names to MigrationResult git-subtree-dir: libbitcoinkernel-sys/bitcoin git-subtree-split: 2df591d0b8497b5b1fb48b762990b829acd5f843
…f591d0b84 2df591d0b84 kernel: Add script tracer f26c15bdd28 Merge bitcoin/bitcoin#35397: ci: add OpenBSD Clang cross job dc282ff31d1 Merge bitcoin/bitcoin#35597: logging: More fully remove libevent log category ec98037f7ae Merge bitcoin/bitcoin#35615: fuzz: restore CreateSock in PCP targets 43d89bb6e10 Merge bitcoin/bitcoin#35610: bitcoin-util: Add netmagic command e35c8054894 Merge bitcoin/bitcoin#35129: test: add fuzz test for private broadcast a318f43254c bitcoin-util: Add netmagic command 3c76bd43568 Merge bitcoin/bitcoin#35603: build: QRencode cleanups 57b3bf84960 Merge bitcoin/bitcoin#35609: ci: Bump tsan config to ubuntu:26.04 with -U_FORTIFY_SOURCE d64ea158240 ci: add openBSD cross CI job 5404b620742 depends: add openbsd_LDFLAGS 2a9e35d293b Merge bitcoin/bitcoin#35588: scripted-diff: Rename `Sock::{RECV,SEND,ERR}` a0e5e30010a fuzz: restore CreateSock in PCP targets 41ceea400e8 scripted-diff: Rename `StatusLevel::{INFO,WARN,ERR}` f395acdeeea scripted-diff: Rename `Sock::{RECV,SEND,ERR}` 7a74f652935 Merge bitcoin/bitcoin#35536: fuzz: share a single mocked steady clock across FuzzedSock instances e1290ce7f74 Merge bitcoin/bitcoin#35543: test: introduce ExtendedPrivateKey and ExtendedPublicKey classes 7ac25c91771 util, refactor: Rename local `ERR` in `Sock::Accept` bbbbab86a81 ci: Bump tsan config to ubuntu:26.04 with -U_FORTIFY_SOURCE ea9afb61a1c Merge bitcoin/bitcoin#35602: doc: Clarify build docs about `pkgconf` / `pkg-config` requirements 672eedc46b0 Merge bitcoin/bitcoin#35220: fuzz: connman: strengthen assertions and extend coverage 0e5c718d8af Merge bitcoin/bitcoin#35506: test: ensure group data cluster pointers are live 93012d7ff91 Merge bitcoin/bitcoin#35601: wallet: remove experimental warning from send and sendall 829255c8bed cmake: Remove `SelectLibraryConfigurations` from `FindQRencode` module 5c55606da9b depends: Remove unused `lib/pkgconfig` in `qrencode` package 402ba10b20b cmake: Drop optional `PkgConfig` use in `FindQRencode` module 8ebfff0f88b doc: add send RPC release note fb8a1038867 doc: Clarify build docs about `pkgconf` / `pkg-config` requirements 5884f5a4fa9 wallet: remove experimental warning from send RPCs 7b84e5106c3 Merge bitcoin/bitcoin#35595: ci: remove some packages from Chimera job 58560c281d0 ci: remove some packages from Chimera job 295ce6f45c8 Merge bitcoin/bitcoin#35576: test: raise `feature_reindex` RPC timeout 633044f1436 Merge bitcoin/bitcoin#35266: rpc, wallet: add an option to not load the wallet after migrating d6269e2a903 Merge bitcoin/bitcoin#35594: fuzz: cover async chainstate compaction 3765b428d19 logging: More fully remove libevent log category 703a671fbc2 fuzz: compact coins view db during fuzzing 0868c85fd57 refactor: rename async coin compaction 6fa4132298a fuzz: share a single mocked steady clock across FuzzedSock instances 8791c4764ca test: use ExtendedPrivateKey in wallet_taproot.py 89ceafafb9f test: use ExtendedPrivateKey in wallet_listdescriptors.py bbfffcab588 test: use ExtendedPrivateKey in wallet_send.py 2ab6e590f73 test: use ExtendedPrivateKey in wallet_keypool.py 9e20118720d test: use ExtendedPrivateKey in wallet_fundrawtransaction.py 06af0cddbb9 test: use ExtendedPrivateKey in wallet_descriptor.py 4100fac20e8 test: use ExtendedPrivateKey in wallet_createwallet.py ff3f6def9a5 test: use ExtendedPrivateKey in wallet_bumpfee.py 003f2a01f63 test: use ExtendedPrivateKey in feature_notifications.py f988e6d6e64 test: use ExtendedPrivateKey in wallet_importdescriptors.py 0cdd817a82a add release note 517d37ce3eb test: tests wallet migration with load_wallet disabled b98dd63da7b rpc: Add load_wallet argument to migratewallet RPC 4acd063ba6f wallet: make loading the wallet after migrating optional 1a3cfdf1b7a fuzz: connman: cover AddLocalServices/RemoveLocalServices c507fb30634 fuzz: connman: add outbound-bytes invariants 4a6fce43ead fuzz: connman: add AddNode/RemoveAddedNode invariants 9e6546c517c test: raise reindex mining RPC timeout d2a03d50acb test: add extendedkey.py unit tests by using BIP32 test vectors afdb3780821 test: introduce ExtendedPrivateKey and ExtendedPublicKey classes 2ee4fafa3f4 test: add fuzz test for private broadcast 08b7c61fc70 private broadcast: enforce sending to unique node ids 4dbaa7cc65b test: generalise byte_to_base58 utility function to allow more version types df9eb72b129 test: ensure group data cluster pointers are live a5859edef45 fuzz: connman: set m_local_services/m_use_addrman_outgoing/m_max_automatic_connections 4b84c9125ad fuzz: connman: add network activity invariants 97d08d62baf refactor: store wallet names to MigrationResult git-subtree-dir: libbitcoinkernel-sys/bitcoin git-subtree-split: 2df591d0b8497b5b1fb48b762990b829acd5f843
…05fc7ab 81405fc7ab Merge bitcoin/bitcoin#35689: test: Inline incorrect check in `util_tests` cd2a4bc510 test: Redeclare variable as signed in `util_tests` 6f1c56f03a Merge bitcoin/bitcoin#35670: net: optimize compact block extra tx iteration e94fda8a40 Merge bitcoin/bitcoin#35685: doc: Archive 30.3 release notes 5223cf1795 Merge bitcoin/bitcoin#35616: refactor: Use u64 over size_t for all cache sizes to fix a 32-bit overflow c0e91efdb3 Merge bitcoin/bitcoin#35295: validation: fetch block input prevouts in parallel during ConnectBlock f0da26cfc8 Merge bitcoin/bitcoin#34997: p2p: Don't participate in addr relay with feelers 443179a9eb doc: Archive 30.3 release notes fabafd91f1 refactor: Use u64 over size_t for all cache sizes to fix a 32-bit overflow 32941e1314 Merge bitcoin/bitcoin#35649: depends: move FreeBSD SDK handling to CI f379d716b1 Merge bitcoin/bitcoin#35669: doc: archive release notes for v31.1 881bb7b355 Merge bitcoin/bitcoin#35673: refactor: Move LoadGenesisBlock to ChainstateManager 3f3e644beb Merge bitcoin/bitcoin#35678: private broadcast: define and use new RPC_LIMIT_EXCEEDED error code ( + other follow-ups) e3b026bf56 Merge bitcoin/bitcoin#34020: mining: add getTransactions(ByWitnessID) IPC methods 62f9089343 Merge bitcoin/bitcoin#35386: doc: add an AI contribution policy fa615bd163 refactor: Move LoadGenesisBlock to ChainstateManager 8ac222484c private broadcast: remove no-op [[nodiscard]] 191bdcba26 test: align test better with described scenario 7ad311be18 test: use BOOST_CHECK_EQUAL for PrivateBroadcast::AddResult 82a02a2a22 rpc: define and use new RPC_LIMIT_EXCEEDED error code a64df338e6 Merge bitcoin/bitcoin#35651: doc: Improve offline-signing-tutorial after 32489 4498fa5d5b Merge bitcoin/bitcoin#35406: private broadcast: limit outstanding txs to count of 10,000 ec5edcd72b Merge bitcoin/bitcoin#35661: Update libmultiprocess subtree to add `ThreadMap.makePool` method ea67fea062 Merge bitcoin/bitcoin#35464: kernel: Add function for creating chainparams with a signet challenge a7b5f23bb8 Merge bitcoin/bitcoin#35667: refactor: Use `NetworkErrorString` for macOS code in `netif.cpp` 69fc991791 Merge bitcoin/bitcoin#32606: p2p: Drop unsolicited CMPCTBLOCK from non-HB peer and when blocksonly 1a3cbf1bd2 net: optimize compact block extra tx iteration bc33509ae2 Merge bitcoin/bitcoin#35650: doc: Add release notes for 32489 (exportwatchonlywallet RPC) 2b6e767d96 doc: archive release notes for v31.1 b0735336ee p2p: Don't participate in addr relay with feeler connections 302733fd96 Merge bitcoin/bitcoin#35652: init: fix reindex deadlock by waking cv after interrupt c1313b199f init: wake genesis wait after ImportBlocks() returns eccb04a321 refactor: Use `NetworkErrorString` for macOS code in `netif.cpp` f79ecfd9c7 Merge bitcoin/bitcoin#35658: refactor: Drop unneeded `<sys/types.h>` include before `<ifaddrs.h>` 22ac4ad949 ci: ensure we use correct lld version in OpenBSD job 495f43f7b3 ci: FreeBSD 15.1 244739db9d depends: move FreeBSD SDK handling to CI bab0120053 Merge bitcoin/bitcoin#35621: validation: Ignore eventual error message from flushing in AcceptBlock 02afa66169 Merge commit '6b0a907302364649dcaffeb0340b985f14141b4e' into pr/subtree-11 6b0a907302 Squashed 'src/ipc/libmultiprocess/' changes from 3edbe8f67c1..16bf05dea02 22c328d388 refactor: Drop unneeded `<sys/types.h>` include before `<ifaddrs.h>` 2063f02bd5 Merge bitcoin/bitcoin#35510: test: SOCKS5 proxy: expect that connection may be reset during SOCKS5 handshake or data forwarding 1360001f43 Merge bitcoin/bitcoin#34959: wallet: Enforce BDB btree levels and overflow item sizes 10ffef4b3b Merge bitcoin/bitcoin#35604: log: expose `-logratelimit` in normal help b393985aa0 Merge bitcoin/bitcoin#35634: txospenderindex: use zero-byte entry values 1835f2fcbf Merge bitcoin/bitcoin#35653: fuzz: Remove `ConsumeUniValue` 9f3e427228 fuzz: Remove ConsumeUniValue 68cb7840d2 doc: improve offline-signing-tutorial after 32489 32ddfc92d9 Merge bitcoin/bitcoin#35599: doc: Add release notes for #33671 (getbalances nonmempool field) f56804bcf5 Merge bitcoin/bitcoin#35640: ci: use a 8x instance over 16x for riscv job 239d6c5260 Merge bitcoin/bitcoin#35614: HTTPServer: Prevent race condition between worker thread and I/O thread cddbad325d doc: Add release notes for 32489 (exportwatchonlywallet RPC) 0a1bbec688 Merge bitcoin/bitcoin#32489: wallet: Add `exportwatchonlywallet` RPC to export a watchonly version of a wallet 4a007126fb Merge bitcoin/bitcoin#35147: depends: Boost 1.91.0-1 31abaa264c doc: add an AI contribution policy a15bdc0598 doc: update offline-signing-tutorial to use exportwatchonlywallet rpc a388076401 test: Test for exportwatchonlywallet d053e3e5c8 wallet, rpc: Add exportwatchonlywallet RPC 444878efef wallet: Add CWallet::ExportWatchOnly f9273f01db wallet: Move listdescriptors retrieving from RPC to CWallet a1c83789a7 wallet: Write new descriptor's cache in AddWalletDescriptor 1e996640e6 wallet: Use Descriptor::CanSelfExpand() in CanGetAddresses() d2ee9227da descriptor: Add CanSelfExpand() 2990bd7735 Merge bitcoin/bitcoin#35118: fuzz: add ipc round-trip fuzz target fb1d152c24 depends: Boost 1.91.0-1 ba48852f9e Merge bitcoin/bitcoin#35438: test: introduce NodeSigner, run feature_taproot.py without wallet compiled 47bbed052e ci: use true|false over "true|false" 9a25bc3989 ci: use a 8x instance over 16x 9871dc7ab4 Merge bitcoin/bitcoin#31425: CI: Add Riscv bare metal job 113402286e doc: add txospenderindex release note ce06878288 index: shrink txospenderindex value markers a99148d576 test kernel: Don't log on warnings change 5b4fd284f4 kernel: Generate a signet with a challenge 037ad77071 fuzz: add IPC round-trip target a8823c0996 Merge bitcoin/bitcoin#35607: nanobench: fix performance counter buffer initialization f26c15bdd2 Merge bitcoin/bitcoin#35397: ci: add OpenBSD Clang cross job 91586f701e test: introduce NodeSigner, run feature_taproot.py without wallet compiled 771200ca43 test: return full keypair from `getnewdestination` helper 4e29de719e private broadcast: add release note for limited cap cbf8c107c1 Release cs_main between individual private tx re-attempts 5aea3d0373 private broadcast: limit outstanding txs to count of 10,000 dc282ff31d Merge bitcoin/bitcoin#35597: logging: More fully remove libevent log category ec98037f7a Merge bitcoin/bitcoin#35615: fuzz: restore CreateSock in PCP targets 43d89bb6e1 Merge bitcoin/bitcoin#35610: bitcoin-util: Add netmagic command e35c805489 Merge bitcoin/bitcoin#35129: test: add fuzz test for private broadcast dc1c17c085 doc: add release notes 0e10937184 fuzz: add coins_view_stacked fuzz harness to test concurrent leveldb reads ce610a6ff4 fuzz: update harnesses to cover CoinsViewOverlay::StartFetching 760fb22dc3 test: add unit tests for CoinsViewOverlay::StartFetching d69a3b20de doc: update CoinsViewOverlay docstring to describe parallel fetching ab2a379237 coins: fetch inputs in parallel fdf283036a coins: add ready flag to InputToFetch ede11b8314 validation: collect block inputs in CoinsViewOverlay before ConnectBlock f82043af50 coins: introduce thread pool in CoinsViewOverlay 5bf1c32008 validation: add -prevoutfetchthreads configuration option a318f43254 bitcoin-util: Add netmagic command 256482ab56 validation: In AcceptBlock, ignore flush result 3c76bd4356 Merge bitcoin/bitcoin#35603: build: QRencode cleanups f595daf1dd test: ensure HTTPServer race condition is fixed b98b10c072 test: introduce a worker thread in http socket error test 922b08d375 test: socket error handling in HTTPServer using ErrorSock mock socket 73da2a8a52 http: prevent race condition between worker thread and I/O thread 57b3bf8496 Merge bitcoin/bitcoin#35609: ci: Bump tsan config to ubuntu:26.04 with -U_FORTIFY_SOURCE d64ea15824 ci: add openBSD cross CI job 5404b62074 depends: add openbsd_LDFLAGS 2a9e35d293 Merge bitcoin/bitcoin#35588: scripted-diff: Rename `Sock::{RECV,SEND,ERR}` a0e5e30010 fuzz: restore CreateSock in PCP targets 41ceea400e scripted-diff: Rename `StatusLevel::{INFO,WARN,ERR}` f395acdeee scripted-diff: Rename `Sock::{RECV,SEND,ERR}` 7a74f65293 Merge bitcoin/bitcoin#35536: fuzz: share a single mocked steady clock across FuzzedSock instances e1290ce7f7 Merge bitcoin/bitcoin#35543: test: introduce ExtendedPrivateKey and ExtendedPublicKey classes 7ac25c9177 util, refactor: Rename local `ERR` in `Sock::Accept` bbbbab86a8 ci: Bump tsan config to ubuntu:26.04 with -U_FORTIFY_SOURCE 095596ddf7 log: expose -logratelimit option ea9afb61a1 Merge bitcoin/bitcoin#35602: doc: Clarify build docs about `pkgconf` / `pkg-config` requirements 672eedc46b Merge bitcoin/bitcoin#35220: fuzz: connman: strengthen assertions and extend coverage 0e5c718d8a Merge bitcoin/bitcoin#35506: test: ensure group data cluster pointers are live b6b1d0653a nanobench: fix perf counter buffer init 93012d7ff9 Merge bitcoin/bitcoin#35601: wallet: remove experimental warning from send and sendall 829255c8be cmake: Remove `SelectLibraryConfigurations` from `FindQRencode` module 5c55606da9 depends: Remove unused `lib/pkgconfig` in `qrencode` package 402ba10b20 cmake: Drop optional `PkgConfig` use in `FindQRencode` module 8ebfff0f88 doc: add send RPC release note fb8a103886 doc: Clarify build docs about `pkgconf` / `pkg-config` requirements 5884f5a4fa wallet: remove experimental warning from send RPCs 7b84e5106c Merge bitcoin/bitcoin#35595: ci: remove some packages from Chimera job 58560c281d ci: remove some packages from Chimera job 295ce6f45c Merge bitcoin/bitcoin#35576: test: raise `feature_reindex` RPC timeout b36730a3ef Add CI job for riscv bare metal bfdbf513f6 Add CI job for producing a static bare metal binary a9a1d92a1d build: Add option for building for bare metal envs 9b2ef81757 doc: add release notes for #33671 (getbalances nonmempool field) 633044f143 Merge bitcoin/bitcoin#35266: rpc, wallet: add an option to not load the wallet after migrating d6269e2a90 Merge bitcoin/bitcoin#35594: fuzz: cover async chainstate compaction 3765b428d1 logging: More fully remove libevent log category 703a671fbc fuzz: compact coins view db during fuzzing 0868c85fd5 refactor: rename async coin compaction 6fa4132298 fuzz: share a single mocked steady clock across FuzzedSock instances 8791c4764c test: use ExtendedPrivateKey in wallet_taproot.py 89ceafafb9 test: use ExtendedPrivateKey in wallet_listdescriptors.py bbfffcab58 test: use ExtendedPrivateKey in wallet_send.py 2ab6e590f7 test: use ExtendedPrivateKey in wallet_keypool.py 9e20118720 test: use ExtendedPrivateKey in wallet_fundrawtransaction.py 06af0cddbb test: use ExtendedPrivateKey in wallet_descriptor.py 4100fac20e test: use ExtendedPrivateKey in wallet_createwallet.py ff3f6def9a test: use ExtendedPrivateKey in wallet_bumpfee.py 003f2a01f6 test: use ExtendedPrivateKey in feature_notifications.py f988e6d6e6 test: use ExtendedPrivateKey in wallet_importdescriptors.py 0cdd817a82 add release note 517d37ce3e test: tests wallet migration with load_wallet disabled b98dd63da7 rpc: Add load_wallet argument to migratewallet RPC 4acd063ba6 wallet: make loading the wallet after migrating optional 1a3cfdf1b7 fuzz: connman: cover AddLocalServices/RemoveLocalServices c507fb3063 fuzz: connman: add outbound-bytes invariants 4a6fce43ea fuzz: connman: add AddNode/RemoveAddedNode invariants 9e6546c517 test: raise reindex mining RPC timeout d2a03d50ac test: add extendedkey.py unit tests by using BIP32 test vectors afdb378082 test: introduce ExtendedPrivateKey and ExtendedPublicKey classes 55e3a57f22 qa: Avoid UTXO reuse between test functions 9c5dd2926a p2p: Ignore CMPCTBLOCK from peer that hasn't sent SENDCMPCT bf9884f4e5 p2p: make blocksonly nodes ignore CMPCTBLOCK messages 92cea63c71 test: (Un)solicited invalid cb -> get disconnected. e845e26344 test: p2p: Nodes ignore unsolicited CMPCTBLOCK's 8313591715 p2p: Drop unsolicited CMPCTBLOCK from non-HB peer 44f377a71f refactor: test: Static assert_highbandwidth_states 25457a3272 test: Tighten getblocktxn checks in parallel cb reconstruction test. 2ee4fafa3f test: add fuzz test for private broadcast 08b7c61fc7 private broadcast: enforce sending to unique node ids 9a8ef9b0a3 test: SOCKS5 proxy: expect that connection may be reset during handshake eb3208364a test: SOCKS5 proxy: expect that connection may be reset when forwarding 4dbaa7cc65 test: generalise byte_to_base58 utility function to allow more version types df9eb72b12 test: ensure group data cluster pointers are live a5859edef4 fuzz: connman: set m_local_services/m_use_addrman_outgoing/m_max_automatic_connections 4b84c9125a fuzz: connman: add network activity invariants 9784818442 mining: add getTransactionsByWitnessID() IPC method d282ae6883 mining: add getTransactionsByTxID() IPC method 0d5e4d4712 test: restart node after IPC option override test f16b3613cd ipc: Serialize null CTransactionRef as empty Data 0f466e1094 mempool: add lookup by witness hash 51dd90fb50 refactor: Merge announce_cmpct_block() defs into one 97d08d62ba refactor: store wallet names to MigrationResult 8a739a5510 build: allow ipc fuzz builds b2de59d486 wallet, bdbro: Validate btree page levels dc3a2b9c3b wallet, bdbro: Enforce overflow data lengths git-subtree-dir: libbitcoinkernel-sys/bitcoin git-subtree-split: 81405fc7abbd1889f3978b8924e7acbe12b3403b
56e5d8a cmake: Remove `SelectLibraryConfigurations` from `FindQRencode` module (Hennadii Stepanov) e546fb2 depends: Remove unused `lib/pkgconfig` in `qrencode` package (Hennadii Stepanov) ca2ee2d cmake: Drop optional `PkgConfig` use in `FindQRencode` module (Hennadii Stepanov) Pull request description: This PR addresses: - [this](bitcoin/bitcoin#35602 (comment)) comment: > If it works without pkg-config, then we should remove the usage of pkgconfig entirely, rather than say it will work without it, and leave the dependency in the code? - and [this](bitcoin/bitcoin#35602 (comment)) one: > While cleaning up this module, you may also get rid of `SelectLibraryConfigurations`. We don't want that `QRencode_LIBRARY` or `QRencode_LIBRARIES` is used anywhere; there is no need to set a variable with that name. ACKs for top commit: purpleKarrot: ACK 56e5d8a Tree-SHA512: fd87a5afd7c0b3271a008df8adcb2ff809053799a0658fbb5a1f15ed11f6abad25836c8e1b7507d0d4c35c027dcbba88b136ac827e17b283ee4ffbbe55d6f4ee
This PR addresses:
this comment:
and this one: