posts: add notice about private broadcast IP leak in 31.0#1255
Conversation
cbdd4d1 to
09c1602
Compare
|
ACK 09c1602 Thanks for taking care of this. Left some nits, I'm also fine with it as is. |
| Until they can upgrade to 31.1, users of `-privatebroadcast` should apply one | ||
| of the following: | ||
|
|
||
| 1. **Disable the feature.** Set `-privatebroadcast=0`. |
There was a problem hiding this comment.
nit: would noprivatebroadcast also work? Probably not worth changing, just thinking out loud...
| 1. **Disable the feature.** Set `-privatebroadcast=0`. | |
| 1. **Disable the feature.** Set `-noprivatebroadcast`. |
There was a problem hiding this comment.
IMO -privatebroadcast=0 is clearer. The -no* prefixes are probably not well known to many users.
There was a problem hiding this comment.
nononononoprivatebroadcast
09c1602 to
d3a8e25
Compare
|
Thanks everyone, updated with latest suggestions. |
|
ACK d3a8e25 Thanks for taking care of this! |
|
Disabling tor and only using clearnet and i2p would also be an effective workaround? That seems to me like the workaround with the least downside. |
vasild
left a comment
There was a problem hiding this comment.
ACK d3a8e25
Disabling tor and only using clearnet and i2p would also be an effective workaround?
Yes.
That seems to me like the workaround with the least downside.
Could be. I find it hard to judge myself. In my addrman there are about 3k I2P addresses and 19k Tor addresses, which is a downside of stopping to use the Tor network. I2P has no exit nodes.
|
ACK d3a8e25 getting message out quicker is better thank you for this |
stickies-v
left a comment
There was a problem hiding this comment.
Concept ACK. Text (d3a8e25) reads fine to me, but did not investigate the bug and its workaround in detail, and not planning to review this more.
This comment was marked as duplicate.
This comment was marked as duplicate.
|
crACK d3a8e25 Text looks good to me, thanks for doing this |
danielabrozzoni
left a comment
There was a problem hiding this comment.
Text ACK d3a8e25
Sorry for commenting late, I had forgotten about this :)
polespinasa
left a comment
There was a problem hiding this comment.
read, looks good to me
ACK d3a8e25
Just curiosity, do we have a functional test or something to try this?
|
@polespinasa bitcoin/bitcoin#35410 and related tests included in comments that didnt make the cut |
|
ACK d3a8e25 |
No description provided.