You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If external callbacks are specified, the build can fail at link time since these functions aren't defined yet. Give the linker some definitions to make it happy.
If you use the external callbacks, then you probably do because you don't have printf or abort on your platform. In tests, we use these function anyway, so I think this change is fine. But wouldn't it be simpler to #undef USE_EXTERNAL_CALLBACKS?
Ideally, we'd move into the other direction and make it possible to run the tests without printf. But that's more complicated.
I wonder if could we just abuse the external callbacks for exactly that purpose? Instead of making CHECK call abort, we could make this macro reset the default callback and then invoke it. If you don't have printf or abort, you'd be able provide a different external callback... Except I don't know how to print the seed then or the final success message. Maybe it's just cleaner to let the user provide some print function...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If external callbacks are specified, the build can fail at link time since these functions aren't defined yet. Give the linker some definitions to make it happy.