Encapsulate relay cache + new tests#496
Open
dagurval wants to merge 1 commit into
Open
Conversation
Collaborator
|
Ok this was quick! Keep up the good work @Dagur! 😄 |
dgenr8
reviewed
Oct 22, 2018
dagurval
commented
Oct 23, 2018
| return; | ||
| } | ||
| int64_t time = GetTime(); | ||
| while (expiration.front().first <= time) { |
Member
Author
There was a problem hiding this comment.
should be expiration.empty() && expiration.front() ... here
Member
There was a problem hiding this comment.
!expiration.empty() but agreed, and suggest remove lines 11-13.
dgenr8
requested changes
Oct 23, 2018
| return; | ||
| } | ||
| int64_t time = GetTime(); | ||
| while (expiration.front().first <= time) { |
Member
There was a problem hiding this comment.
!expiration.empty() but agreed, and suggest remove lines 11-13.
| return ::GetTime(); | ||
| } | ||
|
|
||
| void RelayCache::RemoveExpiration(const uint256& txid) { |
| } | ||
|
|
||
| void RelayCache::RemoveExpiration(const uint256& txid) { | ||
| for (auto e = begin(expiration); e != end(expiration); ++e) { |
Member
There was a problem hiding this comment.
Inefficient but I guess we should rarely get here.
|
|
||
| // Expire tx1 | ||
| cache.time = 100 + RELAY_CACHE_TIMEOUT; | ||
| BOOST_CHECK(cache.FindTx(tx1.GetHash()).IsNull()); |
Member
There was a problem hiding this comment.
Since ExpireOld() is not called, expiration is not being tested. IsNull() passes because setting the version is not sufficient to make it not pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.