Changed JDBC string splitting delimiter#1233
Merged
Merged
Conversation
added 2 commits
September 13, 2018 13:24
…onnection strings for JDBC
ghost
suggested changes
Nov 16, 2018
busbey
approved these changes
Sep 8, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed issue #1184 , currently the JDBC connections Strings are split by
,This hinders the usage of the JDBC auto-failover features as connection String in the form
jdbc:postgresql://host1:port1,host2:port2/databaseare not possible.By simply changing the splitting delimiter to
;auto-failover Strings can be used as well as the existing multiple shards connectionsjdbc:postgresql://host1:port1/database;jdbc:postgresql://host2:port2/databaseUpdated the readme accordingly
Tested with PostgresSQL driver 42.2.5 and CockroachDB 2.0.1