Remove windows-sys#2824
Closed
Jake-Shadle wants to merge 1 commit into
Closed
Conversation
briansmith
reviewed
Apr 27, 2026
|
This change would be great to have, as we're seeing a lot of duplication with the windows crates. |
briansmith
requested changes
Jun 30, 2026
| // SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES | ||
| // WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION | ||
| // OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN | ||
| // CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. |
Owner
There was a problem hiding this comment.
The license and copyright should be the license/copyright of whatever you copied/reduced the bindings from.
Author
|
I just manually wrote this binding from the data in the linked API doc, so I'm not sure what license you want me to put in the header, the windows API doesn't really have a license AFAIK, just a terms of use https://learn.microsoft.com/en-us/legal/microsoft-apis/terms-of-use. |
Owner
|
@Jake-Shadle PTAL at #2865, which uses windows-bindgen to automate the generation. Closing this in favor of that. Thanks for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #2570 that still removes the windows-sys dependency but inlines the bindings (1 function, 1 constant) instead of relying on std.