feat(error): Expose error building blocks#3402
Merged
Merged
Conversation
This is meant to replace `Error::info` as part of clap-rs#2628.
This also makes the intent for the start of an error clearer.
This was referenced Feb 4, 2022
Contributor
|
Can you add a brief example of how users could format errors after this change? Thanks |
Member
Author
It might not stay this way but as of right now, this PR has clap format using Line 687 in b965363 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has some limited programmatic use but the focus is on allowing people to format the errors as they wish.
Downside is that the
.textsection for thegitexample went from 547.9KiB to 566.8KiB.Error::formattedis the sixth largest clap function at 6.0KiB.Fixes #2628
Fixes #3227