vmm: Make sev_snp depend on igvm#8364
Open
rhakobyan wants to merge 1 commit into
Open
Conversation
Member
|
I think this makes sense - thanks! |
0f950d7 to
9e022bb
Compare
Currently both kvm and mshv require an IGVM file to boot a SEV-SNP VM. This is already configured in the top-level cloud-hypervisor Cargo.toml where sev_snp depends on igvm. Add a similar dependency in the vmm crate which helps simplify some of the in-code cfg blocks by removing the ones that are within a sev_snp cfg block. Signed-off-by: Ruben Hakobyan <hruben@meta.com>
9e022bb to
141f958
Compare
Contributor
Author
|
The aarch64 CI failure looks unrelated: |
liuw
approved these changes
Jun 10, 2026
rbradford
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently both kvm and mshv require an IGVM file to boot a SEV-SNP VM. This is already configured in the top-level cloud-hypervisor Cargo.toml where sev_snp depends on igvm.
Add a similar dependency in the vmm crate which helps simplify some of the in-code cfg blocks by removing the ones that are within a sev_snp cfg block.