Skip to content
This repository was archived by the owner on May 15, 2025. It is now read-only.

fix(jupyterlab): don't use -q option#407

Closed
mats16 wants to merge 3 commits into
coder:mainfrom
mats16:patch-1
Closed

fix(jupyterlab): don't use -q option#407
mats16 wants to merge 3 commits into
coder:mainfrom
mats16:patch-1

Conversation

@mats16

@mats16 mats16 commented Feb 18, 2025

Copy link
Copy Markdown

On Ubuntu 22.04, pipx (via apt install) does not have the -q option.
The description that depends on the pipx version should be reduced.

@matifali matifali changed the title Don't use -q option fix(jupyterlab): don't use -q option Feb 18, 2025

@matifali matifali left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. We probbaly did not test it for 22.04

@matifali matifali requested a review from Copilot February 18, 2025 11:29

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • jupyterlab/run.sh: Language not supported

@matifali

Copy link
Copy Markdown
Member

Hi @mats16, can you please take a look at the merge conflict?

@matifali

matifali commented Mar 4, 2025

Copy link
Copy Markdown
Member

We do not use -q anymore after the refactoring in #406

https://github.com/coder/modules/blob/main/jupyterlab/run.sh#L40

@matifali matifali closed this Mar 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants