Skip to content

use std::vector as underlying container for std::stack in simplecpp::TokenList::readfile()#660

Closed
firewave wants to merge 1 commit into
cppcheck-opensource:masterfrom
firewave:readfile
Closed

use std::vector as underlying container for std::stack in simplecpp::TokenList::readfile()#660
firewave wants to merge 1 commit into
cppcheck-opensource:masterfrom
firewave:readfile

Conversation

@firewave

Copy link
Copy Markdown
Collaborator

No description provided.

@firewave

Copy link
Copy Markdown
Collaborator Author

Running ./testrunner in valgrind:

GCC 16 - 73,545,066 -> 72,183,597
Clang 22 - 71,260,479 -> 70,042,899

@firewave firewave marked this pull request as draft June 11, 2026 05:22
@firewave

Copy link
Copy Markdown
Collaborator Author

There is a slight increase with callgrind in the CI which needs looking into first.

@firewave

Copy link
Copy Markdown
Collaborator Author

Closing as the code in question will be removed by #585.

@firewave firewave closed this Jun 11, 2026
@firewave firewave deleted the readfile branch June 11, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant