fix: address incorrect boundary conditions in searchsorted#898
Merged
Conversation
mdhaber
reviewed
Feb 6, 2025
mdhaber
left a comment
Contributor
There was a problem hiding this comment.
This is much better. For maximal clarity within the structure you have proposed, I have a few suggestions.
Co-authored-by: Matt Haberland <mhaberla@calpoly.edu>
Contributor
Author
|
Thanks, @mdhaber, for your review. As all suggestions were accepted, I'll go ahead and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
searchsortedhas incorrect boundary conditions #861 by fixing boundary conditions insearchsorted. The original specification incorrectly described behavior when an index fails to satisfy the index condition. This bug has been addressed and backported to the v2023 revision of the standard.cc @mdhaber