Skip to content

feat(devops): Address zizmor lints#126

Merged
bitdivine merged 16 commits into
mainfrom
address-zizmor-lints
Sep 25, 2025
Merged

feat(devops): Address zizmor lints#126
bitdivine merged 16 commits into
mainfrom
address-zizmor-lints

Conversation

@bitdivine

@bitdivine bitdivine commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

Motivation

The Zizmor linter shows issues with the GitHub config.

Changes

  • Expand GitHub variables to env vars rather than in a shell.
  • Don't persist credentials when not needed.
  • Name tasks
  • Enable the github linter as blocking, now that all issues have been addressed.

Tests

Existing CI should pass.

@bitdivine bitdivine changed the title Address zizmor lints feat(devops): Address zizmor lints Sep 25, 2025

@DecentAgeCoder DecentAgeCoder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@bitdivine bitdivine mentioned this pull request Sep 25, 2025
3 tasks
@bitdivine bitdivine enabled auto-merge (squash) September 25, 2025 13:11

@DecentAgeCoder DecentAgeCoder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@bitdivine bitdivine merged commit 1c9a5e4 into main Sep 25, 2025
13 checks passed
@bitdivine bitdivine deleted the address-zizmor-lints branch September 25, 2025 13:47
bitdivine added a commit that referenced this pull request Sep 25, 2025
# Motivation

We would like to make a maintenance release with updates to less
disruptive dependencies. We plan to update ic-cdk in another release.

## Checklist
- [x] Merge all relevant PRs
  - [x] #126
- [x] Changelog

# Changes
- Update the package version.
- Update the changelog.

# Tests

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants