Globals type fix / Typescript 5.7#57
Closed
marcustyphoon wants to merge 3 commits into
Closed
Conversation
Member
|
Considering that the rewritten website repository no longer depends on @discretize/globals, would it make sense to merge @discretize/globals into the optimizer repository? |
Member
Author
|
I don't understand what led to its creation/what differentiates it from our other repos :D Probably? Possibly? Would someone wanting to make a site with our components generally want any of the code in it? |
Member
|
Sole reason was to share code with the main site. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At time of writing, Typescript 5.7 will throw an error on build because withGw2Theme.jsx in the globals package doesn't sufficiently specify its types. We currently don't export types from that package anyway, but I don't know how to fix the build script to deal with that.
This instead fixes the type (sort of) (it's hacky because it's a jsx file) (note that
@mui/typesprobably has to be a peer dep now also?). See microsoft/TypeScript#58176 (comment).This also thus enables exporting types from the globals package, which is... good? Right? I have no idea what this package is for in the first place so I don't really know.