add support for docker-for-windows new bind serialization format#1463
Merged
Conversation
|
the fix is it include with : build edge 2.4.1.0 (48583) ? |
leCandas
approved these changes
Oct 23, 2020
|
will it be release soon ? still present in docker edge 4.2.x.x |
|
Issue still present in Docker Desktop version 2.5.0.0. |
|
@bsideup can you give a little code review and approve it please. thanks |
bsideup
reviewed
Nov 10, 2020
bsideup
reviewed
Nov 10, 2020
Member
|
@survivant thanks for the ping! The implementation looks okay, I just requested a couple of minor changes, but should be good to go once fixed |
|
@roastario @bsideup just a ping so the bot doesn't close it. Still need it be to able to use it with testcontainer and recent version of Docker. |
Contributor
Author
|
Apologies, I'd accidentally snoozed notifications for this repo. Will look at the comments. |
|
just a ping. |
bsideup
approved these changes
Nov 20, 2020
Member
|
@roastario I just applied a couple of changes myself and will merge once CI is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker-for-windows has recently changed the way it presents bind information (see: #1462) this PR fixes this client + docker-for-windows.