Skip to content

1.17 AuxPoW support#1546

Merged
langerhans merged 6 commits into
dogecoin:1.17-devfrom
rnicoll:1.17-auxpow
Jul 14, 2019
Merged

1.17 AuxPoW support#1546
langerhans merged 6 commits into
dogecoin:1.17-devfrom
rnicoll:1.17-auxpow

Conversation

@rnicoll

@rnicoll rnicoll commented Oct 19, 2018

Copy link
Copy Markdown
Contributor

Add AuxPoW support to 1.17.

This DOES NOT pass lint tests included in 1.17 Travis, and I'm not entirely sure what to do with that as I'd missed it early on, and it's going to take major changes to fix. Leaning on fixing 1.18, but wanted to flag in case you want to tell me it needs correcting before you'll accept.

@rnicoll rnicoll requested a review from langerhans October 19, 2018 22:43
@rnicoll rnicoll changed the title 1.16 AuxPoW support 1.17 AuxPoW support Oct 19, 2018
@rnicoll rnicoll added this to the 1.17 milestone Oct 19, 2018
@rnicoll rnicoll force-pushed the 1.17-auxpow branch 2 times, most recently from c9d75a2 to 0af94b3 Compare April 21, 2019 01:53
@rnicoll

rnicoll commented Apr 21, 2019

Copy link
Copy Markdown
Contributor Author

@langerhans Can you take a look at this please?

Ross Nicoll added 4 commits July 13, 2019 22:25
Changes are as below:

Wrap CBlockHeader::nVersion into a new class (CBlockVersion).  This allows to take care of interpreting the field into a base version, auxpow flag and the chain ID.

Update getauxblock.py for new 'generate' RPC call.

Add 'auxpow' to block JSON.

Accept auxpow as PoW verification.

Add unit tests for auxpow verification.

Add check for memory-layout of CBlockVersion.

Weaken auxpow chain ID checks for the testnet.

Allow Params() to overrule when to check the auxpow chain ID and for legacy blocks.  Use this to disable the checks on testnet.

Introduce CPureBlockHeader.

Split the block header part that is used by auxpow and the "real" block header (that uses auxpow) to resolve the cyclic dependency between the two.

Differentiate between uint256 and arith_uint256.

This change was done upstream, modify the auxpow code.

Add missing lock in auxpow_tests.

Fix REST header check for auxpow headers.

Those can be longer, thus take that into account.  Also perform the check actually on an auxpow header.

Correctly set the coinbase for getauxblock results.

Call IncrementExtraNonce in getauxblock so that the coinbase is actually initialised with the stuff it should be.  (BIP30 block height and COINBASE_FLAGS.)

Implement getauxblock plus regression test.

Turn auxpow test into FIXTURE test.

This allows using of the Params() calls.

Move CMerkleTx code to auxpow.cpp.

Otherwise we get linker errors when building without wallet.

Fix rebase with BIP66.

Update the code to handle BIP66's nVersion=3.

Enforce that auxpow parent blocks have no auxpow block version.

This is for compatibility with namecoind.  See also namecoin/namecoin-legacy#199.

Move auxpow-related parameters to Consensus::Params.
@langerhans langerhans merged commit cee1369 into dogecoin:1.17-dev Jul 14, 2019
@rnicoll rnicoll deleted the 1.17-auxpow branch June 13, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants