ci(release): publish tagged binary assets#36
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
There was a problem hiding this comment.
Review Summary
This PR adds binary asset publishing to GitHub Releases, which is a valuable addition to the release workflow. However, there are two critical issues that will prevent the workflow from functioning:
- Missing checkout step in the
publishjob - thegh release createcommand requires repository context - Artifact version mismatch between upload (v7) and download (v5) actions will cause artifact retrieval to fail
These issues must be fixed before merge to ensure the release workflow executes successfully.
The permission change from read to write is appropriate for publishing release assets.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
| if: startsWith(github.ref, 'refs/tags/v') | ||
| needs: binaries | ||
| runs-on: ubuntu-latest | ||
| steps: |
There was a problem hiding this comment.
🛑 Logic Error: gh release create requires repository context but no checkout step exists. This will cause the command to fail with "not a git repository" error when accessing $GITHUB_REPOSITORY and attempting to create the release.
| steps: | |
| steps: | |
| - uses: actions/checkout@v7 |
| needs: binaries | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/download-artifact@v5 |
There was a problem hiding this comment.
🛑 Compatibility Issue: Version mismatch between upload-artifact@v7 (line 73) and download-artifact@v5 causes artifact retrieval failure. Artifacts uploaded with v7 are incompatible with v5 download action.
| - uses: actions/download-artifact@v5 | |
| - uses: actions/download-artifact@v7 |
Summary
Validation
git diff --check