chore: upgrade eslint#155
Closed
david-luna wants to merge 4 commits into
Closed
Conversation
Member
Author
|
with the Run npm ci
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: eslint-plugin-import@2.29.1
npm ERR! Found: eslint@9.1.1
npm ERR! node_modules/eslint
npm ERR! dev eslint@"^9.1.0" from the root project
npm ERR! peer eslint@"^6.0.0 || ^7.0.0 || >=8.0.0" from @eslint-community/eslint-utils@[4](https://github.com/elastic/elastic-otel-node/actions/runs/8882442044/job/24387150370?pr=155#step:6:5).4.0
npm ERR! node_modules/@eslint-community/eslint-utils
npm ERR! @eslint-community/eslint-utils@"^4.2.0" from eslint@9.1.1
npm ERR! @eslint-community/eslint-utils@"^4.1.2" from eslint-plugin-es-x@7.[5](https://github.com/elastic/elastic-otel-node/actions/runs/8882442044/job/24387150370?pr=155#step:6:6).0
npm ERR! node_modules/eslint-plugin-es-x
npm ERR! eslint-plugin-es-x@"^7.5.0" from eslint-plugin-n@17.3.1
npm ERR! node_modules/eslint-plugin-n
npm ERR! dev eslint-plugin-n@"^17.2.0" from the root project
npm ERR! 1 more (eslint-plugin-n)
npm ERR! 5 more (eslint-compat-utils, eslint-config-prettier, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@"^2 || ^3 || ^4 || ^5 || ^[6](https://github.com/elastic/elastic-otel-node/actions/runs/8882442044/job/24387150370?pr=155#step:6:7) || ^7.2.0 || ^8" from eslint-plugin-import@2.29.1
npm ERR! node_modules/eslint-plugin-import
npm ERR! dev eslint-plugin-import@"^2.29.0" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: eslint@8.5[7](https://github.com/elastic/elastic-otel-node/actions/runs/8882442044/job/24387150370?pr=155#step:6:8).0
npm ERR! node_modules/eslint
npm ERR! peer eslint@"^2 || ^3 || ^4 || ^5 || ^6 || ^7.2.0 || ^[8](https://github.com/elastic/elastic-otel-node/actions/runs/8882442044/job/24387150370?pr=155#step:6:9)" from eslint-plugin-import@2.2[9](https://github.com/elastic/elastic-otel-node/actions/runs/8882442044/job/24387150370?pr=155#step:6:10).1
npm ERR! node_modules/eslint-plugin-import
npm ERR! dev eslint-plugin-import@"^2.29.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /home/runner/.npm/eresolve-report.txt for a full report.
npm ERR! A complete log of this run can be found in:
npm ERR! /home/runner/.npm/_logs/2024-04-29T[17](https://github.com/elastic/elastic-otel-node/actions/runs/8882442044/job/24387150370?pr=155#step:6:18)_00_46_673Z-debug-0.logIt's odd this does not happen in |
Member
Perhaps because apm-agent-nodejs repo has this: |
Member
|
Is there an issue or PR on eslint-plugin-import to have it update its peerDeps to include eslint v9? |
Member
Author
There is an issue to add support to and theres is a draft PR import-js/eslint-plugin-import#2996 so the peerDependencies will be updated in a newer version |
Member
|
Wow, that's a big PR change to eslint-plugin-import. |
This was referenced Jul 1, 2024
trentm
added a commit
that referenced
this pull request
Jul 8, 2024
trentm
added a commit
that referenced
this pull request
Jul 8, 2024
Member
|
Done in #1221 I believe. (Though now there is eslint 10 to upgrade to. Not for this PR though.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
eslintto v9 and switches to the new flat config.