Skip to content

feat: DuckDB historical retrieval without entity dataframe #6108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vperiodt wants to merge 12 commits into
base: master
Choose a base branch
from
Open

feat: DuckDB historical retrieval without entity dataframe #6108

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a8aea3f
support historical retrieval without entity_df
Vperiodt Mar 14, 2026
b2bec2e
test cases
Vperiodt Mar 15, 2026
14d79e8
fix-lint
Vperiodt Mar 15, 2026
10b7f70
fix issue
Vperiodt Mar 16, 2026
2d8252b
fix rename
Vperiodt Mar 16, 2026
c2a6449
addressed reviews
Vperiodt Mar 24, 2026
04d72fd
fix-lint
Vperiodt Apr 10, 2026
ecb84b8
fix-lint
Vperiodt Apr 13, 2026
81df5a2
address-reviews
Vperiodt Apr 16, 2026
ff5471d
fix
Vperiodt Apr 16, 2026
da63740
fix
Vperiodt Apr 17, 2026
9d6ddec
fix
Vperiodt Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix issue 
Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
  • Loading branch information
@Vperiodt
Vperiodt committed Apr 17, 2026
commit 10b7f703269e823a3ae1c4df04e16eb74de5b267
13 changes: 9 additions & 4 deletions sdk/python/feast/infra/offline_stores/duckdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,15 @@ def _build_entity_df_from_sources(
join_key_map = fv.projection.join_key_map or {
e.name: e.name for e in fv.entity_columns
}
join_key_cols = list(join_key_map.values())

if join_key_cols:
distinct_entities = fv_table.select(*join_key_cols).distinct().execute()
source_join_key_cols = list(join_key_map.keys())

if source_join_key_cols:
distinct_entities = (
fv_table.select(*source_join_key_cols)
.rename(join_key_map)
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Outdated
.distinct()
.execute()
)
entity_dfs.append(distinct_entities)

if not entity_dfs:
Expand Down