Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@a80ea92). Click here to learn what that means.

❗ Current head d3dc609 differs from pull request most recent head a89df41. Consider uploading reports for the commit a89df41 to get more accurate results

@@           Coverage Diff           @@
##             main      #77   +/-   ##
=======================================
  Coverage        ?   75.14%           
=======================================
  Files           ?        3           
  Lines           ?     3022           
  Branches        ?        0           
=======================================
  Hits            ?     2271           
  Misses          ?      751           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

We stopped relying on pkg-config to print metadata as we do it manually, see 331bab3

Shouldn't we fix that manual code instead then?

@gdesmott I assume you mean this?

If so, I'll see what I can do.

@gdesmott I found the code, it needs a copy of rust-lang/pkg-config-rs#154 applied. Let me know if this looks OK now.

@gdesmott Hi again, just updated the PR. Could this be reviewed now?

The change seems safe enough now.

Which actual use case is it fixing? Did you check it build and is usable now?

FWIW the pkg-config-rs change that does basically the same is merged and released

@amyspark : sorry I missed your latest update.

Can you please rebase on top of main (I just fixed the CI) so we can merge this?

@gdesmott done, let me know if anything else's needed.

Released in 6.2.1, sorry for the delay.