This repository was archived by the owner on Nov 1, 2017. It is now read-only.
Templetize cURL examples that use usernames and tokens for authentication#346
Merged
Conversation
Contributor
|
As a rule of 👍 when I'm consuming these examples, I generally prefer:
I dig this change. |
Contributor
|
👍 |
Member
Author
|
@pengwynn Ah, that makes a sense and feels natural. 👍 I'll see if there are any other curl requests we can clean up. |
izuzak
added a commit
that referenced
this pull request
Nov 1, 2013
Templetize cURL examples that use usernames and tokens for authentication
jakeboxer
pushed a commit
that referenced
this pull request
Nov 24, 2014
…ange Add blog post for delaying "add team member" API change again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #330, the curl examples in the Authentication docs might be misleading for some users.
For example, users shouldn't try to authenticate as mojombo because it will fail, and some users might think that the way to fix this is to modify the URL somehow (e.g. replace
userwith their username):Instead, I'd like to suggest a templetized approach to the curl command, like so:
Using
:usernameas the format for templetizing might be confusing when not used in the URL. The second curl example in this page demonstrates this problem. So, this could be confusing:but this probably won't be:
cc @gjtorikian @jasonrudolph