Support querying Active Directory Global Catalog#94
Closed
davesims wants to merge 2 commits into
Closed
Conversation
b75644e to
a00750f
Compare
| def active_directory_capability? | ||
| capabilities[:supportedcapabilities].include?(ACTIVE_DIRECTORY_V51_OID) | ||
| end | ||
| private :active_directory_capability? |
Contributor
Author
There was a problem hiding this comment.
Made this public since Domain now needs to pivot on whether the server is an AD or not.
5b54b07 to
3af0a88
Compare
|
|
||
| group :test, :development do | ||
| gem "byebug", :platforms => [:mri_20, :mri_21] | ||
| gem "mocha" |
Contributor
There was a problem hiding this comment.
What's the use case for adding mocha in development?
Contributor
Author
There was a problem hiding this comment.
Mainly as a convenience for cases like this.
Contributor
Author
There was a problem hiding this comment.
Oh, you mean split the group block. 
👍
This was referenced Jul 27, 2016
|
|
||
| group :test do | ||
| gem "mocha" | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Active Directory deployments, in some cases, like authentication or simple entry searches, it will make sense to search the Global Catalog rather than the default configured Domain Controller. This PR will initialize a Global Catalog connection object when requested, and provides an interface to directly query the catalog.
GitHub::Ldap::Domainwill now use the Global Catalog foruser?, if the server is an Active Directory, and the configured Domain Controller is a Global Catalog, or if the user has provided global catalog settings in the initializer options.TODO:
GitHub::Ldap::Domain#user?use the catalog if server is AD & catalog is presentThis begins an alternative approach to #91. To fully replace that, we'll have to also implement referral chasing to be able to search for groups that aren't configured to be Active Directory "universal" groups. I'll do that in a separate PR.
/cc @mtodd @jch @sbryant @lildude @timmjd
/cc @github/ldap