Skip to content

Added more type hinting & Fixed bug when parsing renamed files with spaces and/or non english-symbols #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lyrixx merged 16 commits into from
Aug 5, 2022
Merged

Added more type hinting & Fixed bug when parsing renamed files with spaces and/or non english-symbols #194

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
565526a
changed repo name in the composer
tolik518 Aug 3, 2022
61c8264
added path to the symlink RuntimeException exception-message
tolik518 Aug 3, 2022
2eb7da0
added more and better typehints into PHPDocs above methods
tolik518 Aug 3, 2022
5b1e660
Regex didn't count for the rare case when the diff has quotation mark…
tolik518 Aug 3, 2022
469c47c
replaced uninitialized $entry variable with $element
tolik518 Aug 3, 2022
0b56aab
removed getRevisions() since revisions isn't a part of the Diff object
tolik518 Aug 3, 2022
85866d5
removed unused $fullname in the getCommit() method
tolik518 Aug 3, 2022
112dea5
- added more type hinting
tolik518 Aug 3, 2022
4e18335
- changes that were requested by "
tolik518 Aug 3, 2022
639d691
upped the number of characters that are shown to get a more verbose e…
tolik518 Aug 4, 2022
0db385a
added type annotation for file in the Diff class
tolik518 Aug 4, 2022
462989e
- fixed parser to properly work with files
tolik518 Aug 5, 2022
3316cec
- made fixes for @continuous-integration/styleci/pr
tolik518 Aug 5, 2022
5c6adcd
- made one more fix for @continuous-integration/styleci/pr
tolik518 Aug 5, 2022
f396c08
- switches quotes for @continuous-integration/styleci/pr
tolik518 Aug 5, 2022
94802ae
added trailing \n to the gitignore
tolik518 Aug 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
- switches quotes for @continuous-integration/styleci/pr
  • Loading branch information
@tolik518
tolik518 committed Aug 5, 2022
commit f396c08f3df14c14354be505c3f23595f5640cdf
4 changes: 2 additions & 2 deletions src/Gitonomy/Git/Parser/DiffParser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,10 @@ protected function doParse()

//verifying if the file was deleted or created
if ($this->expects('--- ')) {
$oldName = $this->consumeTo("\n") === "/dev/null" ? '/dev/null' : $oldName;
$oldName = $this->consumeTo("\n") === '/dev/null' ? '/dev/null' : $oldName;
$this->consumeNewLine();
$this->consume('+++ ');
$newName = $this->consumeTo("\n") === "/dev/null" ? '/dev/null' : $newName;
$newName = $this->consumeTo("\n") === '/dev/null' ? '/dev/null' : $newName;
$this->consumeNewLine();
} elseif ($this->expects('Binary files ')) {
$vars = $this->consumeRegexp('/"?(.*?)"? and "?(.*?)"? differ\n/');
Expand Down