Edge case: Empty message in the first commit#217
Merged
Conversation
alexandresalome
approved these changes
Feb 6, 2024
Contributor
Author
|
@lyrixx @alexandresalome any chance to get this in? |
Member
|
Unfortunately, tests are broken and we don't have access to log anymore. Could you rebase & squash? |
Don't try to consume a 2nd new line when the first repository commit has an empty message.
Contributor
Author
|
@lyrixx, rebased and squashed in a single commit |
Contributor
Author
|
I don't see the tests running, but that's probably because PR is from a forked repository? |
Member
|
Looks like you broke the test. Can you have a look at it? |
Contributor
Author
|
@lyrixx, OK, I think I've fixed but still can't see tests running |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #216
Don't try to consume a 2nd new line when the first repository commit has an empty message.